From: Andrew MacLeod <amacleod@redhat.com>
To: Yvan Roux <yvan.roux@linaro.org>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix for PR55492 : __atomic_load doesn't match ACQUIRE memory model
Date: Thu, 29 Nov 2012 17:01:00 -0000 [thread overview]
Message-ID: <50B794D3.7010101@redhat.com> (raw)
In-Reply-To: <CAD57uCc0hVb740SKkdLJf_BQtE=xHJ126zxNtbBeXHCjUn2LGA@mail.gmail.com>
On 11/29/2012 10:42 AM, Yvan Roux wrote:
> Hi,
>
> on ARMv7, the code generated for the __atomic_load builtins in the
> __ATOMIC_ACQUIRE memory model, puts a memory barrier before the load, whereas
> the semantic of the acquire memory model implies a barrier after.
>
> The issue seems to be in expand_atomic_load which puts a memory fence before
> the load in any memory model. The attached patch fixes the problem.
>
Patch is fine.
If you can confirm you have a copyright assignment on file I can take
care of checking it in.
Andrew
next prev parent reply other threads:[~2012-11-29 17:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 15:42 Yvan Roux
2012-11-29 17:01 ` Andrew MacLeod [this message]
2012-11-29 17:10 ` Yvan Roux
2012-11-30 9:37 ` Marcus Shawcroft
2012-11-30 10:15 ` Yvan Roux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B794D3.7010101@redhat.com \
--to=amacleod@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=yvan.roux@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).