From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25727 invoked by alias); 29 Nov 2012 18:03:15 -0000 Received: (qmail 25710 invoked by uid 22791); 29 Nov 2012 18:03:13 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from mx01.qsc.de (HELO mx01.qsc.de) (213.148.129.14) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Nov 2012 18:03:08 +0000 Received: from archimedes.net-b.de (port-92-195-33-30.dynamic.qsc.de [92.195.33.30]) by mx01.qsc.de (Postfix) with ESMTP id E6AF93CD6B; Thu, 29 Nov 2012 19:03:06 +0100 (CET) Message-ID: <50B7A35A.1000309@net-b.de> Date: Thu, 29 Nov 2012 18:03:00 -0000 From: Tobias Burnus User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: "H.J. Lu" CC: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Add --with-build-config=bootstrap-asan support References: <20121122203747.GA4264@gmail.com> <50B79D18.6050601@net-b.de> In-Reply-To: <50B79D18.6050601@net-b.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-11/txt/msg02474.txt.bz2 H.J. Lu wrote: > Please try this: http://gcc.gnu.org/ml/gcc-patches/2012-11/msg01530.html I just did locally "git log -2 -p|patch -p1 -R" - and wait until you sort that out with the patch reviewers, which seemingly didn't like that patch. BTW: I am not sure whether it is possible with the current build system, but I'd prefer: if libsanitizer is not needed (i.e. no bootstrap-asan is used), it is only build as target library in stage2/stage3 and not also in stage1 as host library. Tobias Burnus wrote: > I think that patch has broken bootstrap for me. If I do a normal > bootstrap, Stage1 fails with: I should have quoted more. Note that the "g++" or similar is missing before "-D_GNU_SOURCE": /bin/sh ../libtool --tag=CXX --mode=compile -D_GNU_SOURCE -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I. -I../../../../libsanitizer/interception -I ../../../../libsanitizer/include -Wall -W -Wno-unused-parameter -Wwrite-strings -pedantic -Wno-long-long -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fvisibility=hidden -Wno-variadic-macros -Wno-c99-extensions -g -O2 -D_GNU_SOURCE -MT interception_mac.lo -MD -MP -MF .deps/interception_mac.Tpo -c -o interception_mac.lo ../../../../libsanitizer/interception/interception_mac.cc Thus, for libsanitizer, the $(CXX) variable is not set, when invoked via build root's Makefile. Which gets set via 'CXX=$$(RAW_CXX_FOR_TARGET)' Tobias