public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: Caroline Tice <cmtice@google.com>
Cc: Xinliang David Li <davidxl@google.com>,
	       GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Vtable pointer verification, gcc changes (patch 2 of 2)
Date: Thu, 29 Nov 2012 18:34:00 -0000	[thread overview]
Message-ID: <50B7AAB3.8080903@redhat.com> (raw)
In-Reply-To: <CABtf2+Td7qbF+43dH0Ox=_8VUvLoQSQXSNAgayXHD3=kv2EhwQ@mail.gmail.com>

On 11/16/2012 01:21 PM, Caroline Tice wrote:
> -start_objects (int method_type, int initp)
> +start_objects (int method_type, int initp, const char *extra_name)

I don't think we want to mess with start_objects and such here.  Can't 
you just use

       DECL_STATIC_CONSTRUCTOR (decl) = 1;
       SET_DECL_INIT_PRIORITY (decl, priority);

on your initialization function instead?

Jason

WARNING: multiple messages have this Message-ID
From: Jason Merrill <jason@redhat.com>
To: gcc-patches@gcc.gnu.org
Cc: Xinliang David Li <davidxl@google.com>,
	 GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Vtable pointer verification, gcc changes (patch 2 of 2)
Date: Thu, 29 Nov 2012 18:35:00 -0000	[thread overview]
Message-ID: <50B7AAB3.8080903@redhat.com> (raw)
Message-ID: <20121129183500.Ki4k3YbgKIKtAaC1qEYTgys5VQ6YqJEDRKfQXU4AYzY@z> (raw)
In-Reply-To: <CABtf2+Td7qbF+43dH0Ox=_8VUvLoQSQXSNAgayXHD3=kv2EhwQ@mail.gmail.com>

On 11/16/2012 01:21 PM, Caroline Tice wrote:
> -start_objects (int method_type, int initp)
> +start_objects (int method_type, int initp, const char *extra_name)

I don't think we want to mess with start_objects and such here.  Can't 
you just use

       DECL_STATIC_CONSTRUCTOR (decl) = 1;
       SET_DECL_INIT_PRIORITY (decl, priority);

on your initialization function instead?

Jason

  parent reply	other threads:[~2012-11-29 18:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-05 17:49 Caroline Tice
2012-11-07 16:58 ` Xinliang David Li
2012-11-16 18:21   ` Caroline Tice
     [not found]     ` <CABtf2+SnpddRF9kHsY-CyxNbS+3iQrUM7dqtZmbGJMNkS_WvBw@mail.gmail.com>
2012-11-28 16:17       ` Fwd: " Diego Novillo
2012-11-29 18:34     ` Jason Merrill [this message]
2012-11-29 18:35       ` Jason Merrill
2012-11-08  9:36 ` Florian Weimer
2012-11-08 16:56   ` Caroline Tice

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B7AAB3.8080903@redhat.com \
    --to=jason@redhat.com \
    --cc=cmtice@google.com \
    --cc=davidxl@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).