From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15750 invoked by alias); 6 Dec 2012 14:13:26 -0000 Received: (qmail 15742 invoked by uid 22791); 6 Dec 2012 14:13:25 -0000 X-SWARE-Spam-Status: No, hits=-7.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Dec 2012 14:13:20 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB6EDKJi020593 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 6 Dec 2012 09:13:20 -0500 Received: from [10.3.113.167] (ovpn-113-167.phx2.redhat.com [10.3.113.167]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qB6EDJGN004545; Thu, 6 Dec 2012 09:13:19 -0500 Message-ID: <50C0A7FF.2070203@redhat.com> Date: Thu, 06 Dec 2012 14:13:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Jakub Jelinek CC: gcc-patches@gcc.gnu.org Subject: Re: [C++ PATCH] Handle VECTOR_CSTs in adjust_temp_type (PR c++/55573) References: <20121206071640.GF2315@tucnak.redhat.com> In-Reply-To: <20121206071640.GF2315@tucnak.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-12/txt/msg00394.txt.bz2 On 12/06/2012 02:16 AM, Jakub Jelinek wrote: > With Marc's recent changes to fold vector CONSTRUCTORs into VECTOR_CSTs > if possible, we now ICE in adjust_temp_type, because the type of VECTOR_CST > is not SCALAR_TYPE_P. Either we can handle VECTOR_CSTs directly > (in that case ignore_overflows is also called on each VECTOR_CST constant, > but not sure if that is needed), as done in the patch below, or > Marc has an alternative patch to just change the assert into > gcc_assert (scalarish_type_p); > Which way do you prefer? If Marc's patch works, let's go with that. > BTW, the PR and the referenced PR contains some other patches, e.g. > cp_tree_equal not handling VECTOR_CSTs. For that it is a similar question, > either VECTOR_CSTs can be handled there using operand_equal_p, or > by calling cp_tree_equal on the VECTOR_CST elements. Let's go with the operand_equal_p option; less code duplication is good. Jason