From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29988 invoked by alias); 7 Dec 2012 10:10:21 -0000 Received: (qmail 29973 invoked by uid 22791); 7 Dec 2012 10:10:19 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_NO,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 Dec 2012 10:10:14 +0000 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id qB7AACDQ001928 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 7 Dec 2012 10:10:13 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id qB7AACaZ013630 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 7 Dec 2012 10:10:12 GMT Received: from abhmt116.oracle.com (abhmt116.oracle.com [141.146.116.68]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id qB7AACuZ014810; Fri, 7 Dec 2012 04:10:12 -0600 Received: from [192.168.1.4] (/79.52.234.135) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 07 Dec 2012 02:10:12 -0800 Message-ID: <50C1C082.4020601@oracle.com> Date: Fri, 07 Dec 2012 10:10:00 -0000 From: Paolo Carlini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Matthias Klose CC: Jakub Jelinek , Jason Merrill , gcc-patches List Subject: Re: C++ PATCH for c++/54325 (wrong error initializing abstract base class) References: <50C1790B.3040704@redhat.com> <50C1B327.9060006@ubuntu.com> <20121207091715.GQ2315@tucnak.redhat.com> <50C1B5E1.2000602@ubuntu.com> In-Reply-To: <50C1B5E1.2000602@ubuntu.com> Content-Type: multipart/mixed; boundary="------------010402060802050103090109" X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-12/txt/msg00471.txt.bz2 This is a multi-part message in MIME format. --------------010402060802050103090109 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 360 Hi, On 12/07/2012 10:24 AM, Matthias Klose wrote: > committed. > > Matthias > > 2012-12-07 Matthias Klose > > * tree.c (build_aggr_init_expr): Add parameter name, mark as unused. Thanks. I was wondering if in mainline we could just do the below. It seems straightforward enough... Thanks! Paolo. /////////////////////// --------------010402060802050103090109 Content-Type: text/plain; charset=UTF-8; name="CL" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="CL" Content-length: 222 2012-12-07 Paolo Carlini * tree.c (build_aggr_init_expr): Remove tsubst_flags_t parameter. (build_cplus_new): Adjust. * cp-tree.h: Adjust declaration. * init.c (build_value_init): Adjust. --------------010402060802050103090109 Content-Type: text/plain; charset=UTF-8; name="patchlet" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="patchlet" Content-length: 2249 Index: cp-tree.h =================================================================== --- cp-tree.h (revision 194296) +++ cp-tree.h (working copy) @@ -5762,7 +5762,7 @@ extern tree build_min_nt_loc (location_t, enum t extern tree build_min_non_dep (enum tree_code, tree, ...); extern tree build_min_non_dep_call_vec (tree, tree, vec *); extern tree build_cplus_new (tree, tree, tsubst_flags_t); -extern tree build_aggr_init_expr (tree, tree, tsubst_flags_t); +extern tree build_aggr_init_expr (tree, tree); extern tree get_target_expr (tree); extern tree get_target_expr_sfinae (tree, tsubst_flags_t); extern tree build_cplus_array_type (tree, tree); Index: init.c =================================================================== --- init.c (revision 194296) +++ init.c (working copy) @@ -350,8 +350,7 @@ build_value_init (tree type, tsubst_flags_t compla (type, build_special_member_call (NULL_TREE, complete_ctor_identifier, NULL, type, LOOKUP_NORMAL, - complain), - complain); + complain)); else if (TYPE_HAS_COMPLEX_DFLT (type)) { /* This is a class that needs constructing, but doesn't have @@ -361,7 +360,7 @@ build_value_init (tree type, tsubst_flags_t compla tree ctor = build_special_member_call (NULL_TREE, complete_ctor_identifier, NULL, type, LOOKUP_NORMAL, complain); - ctor = build_aggr_init_expr (type, ctor, complain); + ctor = build_aggr_init_expr (type, ctor); if (ctor != error_mark_node) AGGR_INIT_ZERO_FIRST (ctor) = 1; return ctor; Index: tree.c =================================================================== --- tree.c (revision 194296) +++ tree.c (working copy) @@ -407,7 +407,7 @@ build_aggr_init_array (tree return_type, tree fn, callable. */ tree -build_aggr_init_expr (tree type, tree init, tsubst_flags_t /*complain*/) +build_aggr_init_expr (tree type, tree init) { tree fn; tree slot; @@ -469,7 +469,7 @@ tree tree build_cplus_new (tree type, tree init, tsubst_flags_t complain) { - tree rval = build_aggr_init_expr (type, init, complain); + tree rval = build_aggr_init_expr (type, init); tree slot; /* Make sure that we're not trying to create an instance of an --------------010402060802050103090109--