From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7410 invoked by alias); 11 Dec 2012 16:40:52 -0000 Received: (qmail 7400 invoked by uid 22791); 11 Dec 2012 16:40:50 -0000 X-SWARE-Spam-Status: No, hits=-7.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Dec 2012 16:40:45 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBBGeiOJ008302 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 11 Dec 2012 11:40:44 -0500 Received: from [10.3.113.19] ([10.3.113.19]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBBGeYI2026566; Tue, 11 Dec 2012 11:40:40 -0500 Message-ID: <50C76202.8040909@redhat.com> Date: Tue, 11 Dec 2012 16:40:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Dodji Seketeli CC: GCC Patches Subject: Re: [PATCH] PR c++/53609 - Wrong argument deduction for pack expansion in argument pack References: <50A6C0B0.8070407@redhat.com> <87vccjclke.fsf@redhat.com> <50BF6FCC.90907@redhat.com> <87ip8cb3d1.fsf@redhat.com> <50C66442.9010903@redhat.com> <87hansa8hz.fsf@redhat.com> In-Reply-To: <87hansa8hz.fsf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-12/txt/msg00710.txt.bz2 On 12/11/2012 10:55 AM, Dodji Seketeli wrote: > Oops, it seems I was too hasty in trying to do away with the > instantiation_yields_no_list_p parameter to > gen_elem_of_pack_expansion_instantiation. I still think that the elem function should just deal with the single element case; the cases where we can't do a piecewise substitution should be handled outside the elem function. >> I suppose we should keep this for has_empty_arg, but I'd like to do >> away with special handling of the arg_from_parm_pack case if possible, >> as it's a lot of extra complexity. > > OK, done. Looks like you only removed the check from that one if; I'd like to do away with the arg_from_parm_pack function entirely if we can. Jason