From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32128 invoked by alias); 18 Dec 2012 16:36:44 -0000 Received: (qmail 31888 invoked by uid 22791); 18 Dec 2012 16:36:41 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Dec 2012 16:36:09 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Tue, 18 Dec 2012 16:36:07 +0000 Received: from [10.1.69.67] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 18 Dec 2012 16:36:06 +0000 Message-ID: <50D09B75.6080509@arm.com> Date: Tue, 18 Dec 2012 16:36:00 -0000 From: Richard Earnshaw User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 MIME-Version: 1.0 To: James Greenhalgh CC: "gcc-patches@gcc.gnu.org" , Marcus Shawcroft Subject: Re: [AArch64] Fix some warnings about unused variables. References: <1355839344-13411-1-git-send-email-james.greenhalgh@arm.com> In-Reply-To: <1355839344-13411-1-git-send-email-james.greenhalgh@arm.com> X-MC-Unique: 112121816360717401 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-12/txt/msg01134.txt.bz2 On 18/12/12 14:02, James Greenhalgh wrote: > Hi, > > This straightforward patch fixes the following warnings I see when buildi= ng > for AArch64. > > gcc/config/aarch64/aarch64.c:6385:7: warning: unused variable =E2=80=98re= g=E2=80=99 [-Wunused-variable] > gcc/config/aarch64/aarch64.c:6385:12: warning: unused variable =E2=80=98m= em=E2=80=99 [-Wunused-variable] > gcc/config/aarch64/aarch64.c:6385:17: warning: unused variable =E2=80=98a= ddr=E2=80=99 [-Wunused-variable] > gcc/config/aarch64/aarch64.c:6386:7: warning: unused variable =E2=80=98lo= ad=E2=80=99 [-Wunused-variable] > gcc/config/aarch64/aarch64.c:6669:17: warning: variable =E2=80=98mod_s=E2= =80=99 set but not used [-Wunused-but-set-variable] > > Regression tested on aarch64-none-elf with no regressions and checked > to ensure that the warnings go away. > > OK to commit? > OK. R. > Thanks, > James Greenhalgh > > --- > gcc/ > > 2012-12-18 James Greenhalgh > > * config/aarch64/aarch64.c (aarch64_simd_attr_length_move): > Remove unused variables. > (aarch64_split_compare_and_swap): Likewise. > > > 0001-AArch64-Fix-some-warnings-about-unused-variables.patch > > > diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c > index 09b1777..03b1361 100644 > --- a/gcc/config/aarch64/aarch64.c > +++ b/gcc/config/aarch64/aarch64.c > @@ -6382,8 +6382,6 @@ aarch64_simd_disambiguate_copy (rtx *operands, rtx = *dest, > int > aarch64_simd_attr_length_move (rtx insn) > { > - rtx reg, mem, addr; > - int load; > enum machine_mode mode; > > extract_insn_cached (insn); > @@ -6666,7 +6664,6 @@ aarch64_split_compare_and_swap (rtx operands[]) > { > rtx rval, mem, oldval, newval, scratch; > enum machine_mode mode; > - enum memmodel mod_s; > bool is_weak; > rtx label1, label2, x, cond; > > @@ -6675,7 +6672,6 @@ aarch64_split_compare_and_swap (rtx operands[]) > oldval =3D operands[2]; > newval =3D operands[3]; > is_weak =3D (operands[4] !=3D const0_rtx); > - mod_s =3D (enum memmodel) INTVAL (operands[5]); > scratch =3D operands[7]; > mode =3D GET_MODE (mem); > >