From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28216 invoked by alias); 24 Dec 2012 14:57:24 -0000 Received: (qmail 28182 invoked by uid 22791); 24 Dec 2012 14:57:23 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_IB X-Spam-Check-By: sourceware.org Received: from mail-wg0-f46.google.com (HELO mail-wg0-f46.google.com) (74.125.82.46) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Dec 2012 14:57:16 +0000 Received: by mail-wg0-f46.google.com with SMTP id dr13so3197945wgb.25 for ; Mon, 24 Dec 2012 06:57:15 -0800 (PST) X-Received: by 10.180.20.177 with SMTP id o17mr27525391wie.24.1356361035444; Mon, 24 Dec 2012 06:57:15 -0800 (PST) Received: from yakj.usersys.redhat.com (93-34-179-137.ip50.fastwebnet.it. [93.34.179.137]) by mx.google.com with ESMTPS id p2sm33569248wic.7.2012.12.24.06.57.12 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 24 Dec 2012 06:57:13 -0800 (PST) Message-ID: <50D86D47.2050907@gnu.org> Date: Mon, 24 Dec 2012 14:57:00 -0000 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Alexandre Oliva CC: gcc-patches@gcc.gnu.org, Tobias Burnus Subject: Re: fix libquadmath build regression References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-12/txt/msg01390.txt.bz2 Il 21/12/2012 06:17, Alexandre Oliva ha scritto: > Revision 193063 brought in calls to fraiseexcept() into libquadmath, > which caused a build regression on Fedora 16 (BLAG 160k actually) x86_64 > while building an i686-linux-gnu native toolchain. > > The problem is that glibc has an extern inline definition of > fraiseexcept that is introduced by including fenv.h (it's in > bits/fenv.h), and this definition requires SSE support regardless of > target arch of word width, so it doesn't work for an i686 native that > doesn't assume SSE registers and instructions are available. > > This bug is fixed in newer versions of glibc, but I figured it wouldn't > hurt to have a work-around in place for libquadmath to build, detecting > that the extern inline in the header is broken and introducing a wrapper > that bypasses the header so as to use the out-of-line definition in the > math library. > > Is this ok to install? Would it be possible to fix it in fixincludes instead? Paolo