public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [patch, fortran] lang.opt: Adjust documentation.
@ 2007-03-24 19:29 Brooks Moses
  2007-03-24 20:21 ` FX Coudert
  2007-03-25 20:49 ` Mike Stump
  0 siblings, 2 replies; 5+ messages in thread
From: Brooks Moses @ 2007-03-24 19:29 UTC (permalink / raw)
  To: gcc-patches; +Cc: fortran

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

This patch edits a few descriptions in lang.opt.  The reason that it's 
not committed as obvious is that it removes -fpreprocessed from the 
"gfortran --help" output.  (It's not documented in the invoke.texi 
documentation either.)  As best I could tell from how this is used, it 
seems to be a "for internal use only" option, but I'm not sure of that 
and would like to have confirmation before committing this.  Comments, 
anyone?

------------------------------------------------------------------
2007-03-24  Brooks Moses  <brooks.moses@codesourcery.com>

	* lang.opt: Minor edits to descriptions.

------------------------------------------------------------------

Tested with "make check-fortran" on i686-pc-linux-gnu.  Ok for mainline?

Thanks much!
- Brooks


[-- Attachment #2: lang-opt-descriptions.diff --]
[-- Type: text/x-patch, Size: 578 bytes --]

Index: lang.opt
===================================================================
--- lang.opt	(revision 123170)
+++ lang.opt	(working copy)
@@ -219,11 +219,11 @@
 
 fpack-derived
 Fortran
-Try to layout derived types as compact as possible
+Try to lay out derived types as compactly as possible
 
 fpreprocessed
 Fortran
-Treat the input file as preprocessed
+; For internal use only: Treat the input file as preprocessed
 
 frange-check
 Fortran
@@ -263,7 +263,7 @@
 
 std=gnu
 Fortran
-Conform nothing in particular
+Conform to nothing in particular
 
 std=legacy
 Fortran

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [patch, fortran] lang.opt: Adjust documentation.
  2007-03-24 19:29 [patch, fortran] lang.opt: Adjust documentation Brooks Moses
@ 2007-03-24 20:21 ` FX Coudert
  2007-03-25 20:49 ` Mike Stump
  1 sibling, 0 replies; 5+ messages in thread
From: FX Coudert @ 2007-03-24 20:21 UTC (permalink / raw)
  To: Brooks Moses; +Cc: fortran, gcc-patches

> This patch edits a few descriptions in lang.opt.  The reason that  
> it's not committed as obvious is that it removes -fpreprocessed  
> from the "gfortran --help" output.  (It's not documented in the  
> invoke.texi documentation either.)  As best I could tell from how  
> this is used, it seems to be a "for internal use only" option, but  
> I'm not sure of that and would like to have confirmation before  
> committing this.  Comments, anyone?

How does that relate to your old post about this same option (- 
fpreprocessed)? (see http://gcc.gnu.org/ml/fortran/2006-11/ 
msg00281.html)

I also think it's for internal use only (and Google doesn't mention  
anyone non-internal use), so I am all for your patch. OK after  
waiting a few days, to let people complain.

FX

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [patch, fortran] lang.opt: Adjust documentation.
  2007-03-24 19:29 [patch, fortran] lang.opt: Adjust documentation Brooks Moses
  2007-03-24 20:21 ` FX Coudert
@ 2007-03-25 20:49 ` Mike Stump
  2007-03-25 23:29   ` Brooks Moses
  1 sibling, 1 reply; 5+ messages in thread
From: Mike Stump @ 2007-03-25 20:49 UTC (permalink / raw)
  To: Brooks Moses; +Cc: gcc-patches, fortran

On Mar 24, 2007, at 11:06 AM, Brooks Moses wrote:
> fpreprocessed
>  Fortran
> -Treat the input file as preprocessed
> +; For internal use only: Treat the input file as preprocessed

The Undocumented tag comes to mind, though, I will note that this  
flag is documented for C.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [patch, fortran] lang.opt: Adjust documentation.
  2007-03-25 20:49 ` Mike Stump
@ 2007-03-25 23:29   ` Brooks Moses
  2007-03-26 21:50     ` Brooks Moses
  0 siblings, 1 reply; 5+ messages in thread
From: Brooks Moses @ 2007-03-25 23:29 UTC (permalink / raw)
  To: gcc-patches; +Cc: fortran

Mike Stump wrote:
> On Mar 24, 2007, at 11:06 AM, Brooks Moses wrote:
>> fpreprocessed
>>  Fortran
>> -Treat the input file as preprocessed
>> +; For internal use only: Treat the input file as preprocessed
> 
> The Undocumented tag comes to mind, though, I will note that this  
> flag is documented for C.

Indeed.  As FX reminded me, when I was looking into this a half-year ago 
I discovered that using the Undocumented tag in fortran/lang.opt didn't 
affect anything since it was documented in C.  However, that was with 
the old --help system, and I'm not sure how the new one handles this.

Currently, something seems to be broken in the gcc -v --help output for 
C and C++ (it's reporting "The following options are specific to the 
language C: No options with the desired characteristics were found"), so 
I can't actually tell what this is doing.  However, the new system does 
seem to be written under the assumption that all *.opt files that list 
an option give it the same documentation string, so I will apply the 
other parts of this patch but leave this bit out.

Thanks!
- Brooks, who just filed PRs 31349 through 31352 about the --help output 
while tracking this down.  :)

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [patch, fortran] lang.opt: Adjust documentation.
  2007-03-25 23:29   ` Brooks Moses
@ 2007-03-26 21:50     ` Brooks Moses
  0 siblings, 0 replies; 5+ messages in thread
From: Brooks Moses @ 2007-03-26 21:50 UTC (permalink / raw)
  To: gcc-patches; +Cc: fortran

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

Brooks Moses wrote:
> Currently, something seems to be broken in the gcc -v --help output for 
> C and C++ (it's reporting "The following options are specific to the 
> language C: No options with the desired characteristics were found"), so 
> I can't actually tell what this is doing.  However, the new system does 
> seem to be written under the assumption that all *.opt files that list 
> an option give it the same documentation string, so I will apply the 
> other parts of this patch but leave this bit out.

And committed, as attached.

- Brooks

[-- Attachment #2: lang-opt-descriptions_2.diff --]
[-- Type: text/x-patch, Size: 450 bytes --]

Index: lang.opt
===================================================================
--- lang.opt	(revision 123170)
+++ lang.opt	(working copy)
@@ -219,7 +219,7 @@
 
 fpack-derived
 Fortran
-Try to layout derived types as compact as possible
+Try to lay out derived types as compactly as possible
 
 fpreprocessed
 Fortran
@@ -263,7 +263,7 @@
 
 std=gnu
 Fortran
-Conform nothing in particular
+Conform to nothing in particular
 
 std=legacy
 Fortran

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2007-03-26 21:40 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-03-24 19:29 [patch, fortran] lang.opt: Adjust documentation Brooks Moses
2007-03-24 20:21 ` FX Coudert
2007-03-25 20:49 ` Mike Stump
2007-03-25 23:29   ` Brooks Moses
2007-03-26 21:50     ` Brooks Moses

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).