From: Bruce Korb <bkorb@gnu.org>
To: Paolo Bonzini <bonzini@gnu.org>
Cc: Alexandre Oliva <aoliva@redhat.com>,
gcc-patches@gcc.gnu.org, Tobias Burnus <burnus@net-b.de>
Subject: Re: fixincludes for libquadmath build regression
Date: Sun, 30 Dec 2012 22:26:00 -0000 [thread overview]
Message-ID: <50E0BF99.9060807@gnu.org> (raw)
In-Reply-To: <50E00C7D.7030701@gnu.org>
On 12/30/12 01:42, Paolo Bonzini wrote:
> Not my territory anymore, but it looks much better! CCing Bruce.
Hi Alexandre,
Long time. It's no wonder you've forgotten this little world! :)
Anyway, please make the expressions more readable and strip
out the generated text from the review message.
Readability guidance: indent text and break lines logically.
Consider "here-strings". e.g. not:
c_fix_arg = "# ifdef __SSE_MATH__\n%0\n"
"# else\n%1__asm__ __volatile__ (\"fdiv %%%%st, %%%%st(0); fwait\"\n"
"%1\t\t\t: \"=t\" (__f) : \"0\" (__f));\n"
"# endif";
instead:
c_fix_arg = "# ifdef __SSE_MATH__\n%0\n"
"# else\n"
"%1__asm__ __volatile__ (\"fdiv %%%%st, %%%%st(0); fwait\"\n"
"%1\t\t\t: \"=t\" (__f) : \"0\" (__f));\n"
"# endif";
or even better:
c_fix_arg = <<- _EOText_
# ifdef __SSE_MATH__\n
%0
# else
%1__asm__ __volatile__ ("fdiv %%%%st, %%%%st(0); fwait"
%1 "=t" (__f) : "0" (__f));
# endif
_EOText_;
next prev parent reply other threads:[~2012-12-30 22:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 5:17 fix " Alexandre Oliva
2012-12-21 10:32 ` Tobias Burnus
2012-12-30 0:17 ` Alexandre Oliva
2012-12-24 14:57 ` Paolo Bonzini
2012-12-30 0:13 ` Alexandre Oliva
2012-12-30 9:42 ` Paolo Bonzini
2012-12-30 22:26 ` Bruce Korb [this message]
2013-01-06 20:12 ` fixincludes for " Alexandre Oliva
2013-01-06 20:44 ` Bruce Korb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E0BF99.9060807@gnu.org \
--to=bkorb@gnu.org \
--cc=aoliva@redhat.com \
--cc=bonzini@gnu.org \
--cc=burnus@net-b.de \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).