From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-335110-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 11567 invoked by alias); 7 Jan 2013 20:36:17 -0000
Received: (qmail 11504 invoked by uid 22791); 7 Jan 2013 20:36:16 -0000
X-SWARE-Spam-Status: No, hits=-7.0 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Jan 2013 20:36:10 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r07Ka8eF008096	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 7 Jan 2013 15:36:09 -0500
Received: from anchor.twiddle.home (vpn-234-221.phx2.redhat.com [10.3.234.221])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r07Ka7R6008587;	Mon, 7 Jan 2013 15:36:08 -0500
Message-ID: <50EB31B7.9090307@redhat.com>
Date: Mon, 07 Jan 2013 20:36:00 -0000
From: Richard Henderson <rth@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: Rong Xu <xur@google.com>
CC: Richard Biener <richard.guenther@gmail.com>,        Andrew Pinski <pinskia@gmail.com>,        Xinliang David Li <davidxl@google.com>, Jan Hubicka <hubicka@ucw.cz>,        GCC Patches <gcc-patches@gcc.gnu.org>,        reply@codereview.appspotmail.com
Subject: Re: atomic update of profile counters (issue7000044)
References: <20121221064539.0E1A7100704@rong.mtv.corp.google.com>	<20121221092532.GA7055@kam.mff.cuni.cz>	<CAF1bQ=R7pXzBq08E7PiXKwahpM8Lx0gergnXvGtr6wk+M8-nKA@mail.gmail.com>	<CAF1bQ=Qs8uSHmPp01vwYm-vU4XD+wYrB4cEAcAib8i7LDAS3og@mail.gmail.com>	<CAAkRFZKPOUdHdF2XZDYkncj8=Z_yg2OosmxN6hyZ=877sqoVxg@mail.gmail.com>	<CAF1bQ=QE0UPcWzG8U150E8cMK4WrcXwiNBgdeDgZPhV5KUx9wA@mail.gmail.com>	<CA+=Sn1kK-Ld-K7YBAy1rVTrkBaXhduRH6zE4LA379QTgiY-1wA@mail.gmail.com>	<CAFiYyc33X_tX6csqC880dVYm=AM51PQ3uZX4Bx+7wi0V1UP6Bg@mail.gmail.com> <CAF1bQ=R-5ipC+8+MAqsOpyMJ9DQ2X6fw-S3Z0sMKnQ6B9Zz3XQ@mail.gmail.com>
In-Reply-To: <CAF1bQ=R-5ipC+8+MAqsOpyMJ9DQ2X6fw-S3Z0sMKnQ6B9Zz3XQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2013-01/txt/msg00353.txt.bz2

On 01/03/2013 04:42 PM, Rong Xu wrote:
> It links libatomic when -fprofile-gen-atomic is specified for FDO
> instrumentation build. Here I assume libatomic is always installed.
> Andrew: do you think if this is reasonable?
> 
> It also disables the functionality if target does not support weak
> (ie. TARGET_SUPPORTS_WEAK == 0).

Since you're linking libatomic, you don't need weak references.

I think its ok to assume libatomic is installed, given that the
user has had to explicitly use the command-line option.


r~