Re: testsuite: missing or wrong dg-* directives?

[Manfred Schwarb <manfred99@gmx.ch>]

Am 14.01.2013 00:10, schrieb Manfred Schwarb:
> Am 13.01.2013 21:30, schrieb Harald Anlauf:
>> On 01/12/13 22:02, Mikael Morin wrote:
>>> Le 08/01/2013 22:32, Harald Anlauf a écrit :
>>>> On 12/28/12 21:49, Harald Anlauf wrote:
>>>>> Hello all,
>>>>>
>>>>> is there a default directive that is assumed when the testsuite is run?
>>>>>
>>>>> Running an "fgrep -L" on the fortran testsuite, I found several files
>>>>> that are missing either dg-do compile or run.
>>>>>
>>>>> I also found a funny typo in gomp/appendix-a/a.11.2.f90
>>>>> ! { do-do compile }
>>>>
>
> There are several other oddities: d_g-final, braces have to be separated by spaces.
> Not sure about the double braces in lto, I guess they act simply as single braces.
>


Oh, and then there is the "dg-do  run" hack (two spaces, see cray_pointers_2.f90).
I guess the other occurrences are not intended:

default_initialization_5.f90:! { dg-do  run }
io_real_boz_3.f90:! { dg-do  run }
io_real_boz_4.f90:! { dg-do  run }
io_real_boz_5.f90:! { dg-do  run }


> class_array_10.f03:! { dg-do compile}
> coarray_lib_token_4.f90:! { d_g-final { scan-tree-dump-times "bar \\(&parm.\[0-9\]+, caf_token.\[0-9\]+, \\(\\(integer\\(kind=.\\) parm.\[0-9\]+.data - \\(integer\\(kind=.\\)\\) x.\[0-9\]+\\) \\+ caf_offset.\[0-9\]+\\);" 1 "original" } }
> continuation_9.f90:! { dg-warning "not allowed by itself in line 3" "" {target "*-*-*"} 0 }
> continuation_9.f90:! { dg-warning "not allowed by itself in line 4" "" {target "*-*-*"} 0 }
> continuation_9.f90:! { dg-warning "not allowed by itself in line 5" "" {target "*-*-*"} 0 }
> extends_11.f03:! { dg-final { scan-tree-dump-times " +recruit\\.service\\.education\\.person\\.ss =" 8 "original"} }
> lto/20091016-1_0.f90:! { dg-lto-options {{-flto -g -fPIC -r -nostdlib} {-O -flto -g -fPIC -r -nostdlib}} }
> lto/20100110-1_0.f90:! { dg-lto-options {{ -O1 -flto }} }
> lto/pr41521_0.f90:! { dg-lto-options {{-g -flto} {-g -O -flto}} }
> lto/pr46036_0.f90:! { dg-lto-options {{ -O -flto -ftree-vectorize }} }
> lto/pr46629_0.f90:! { dg-lto-options {{ -O2 -flto -ftree-vectorize -march=x86-64 }} { target i?86-*-* x86_64-*-* } }
> lto/pr46629_0.f90:! { dg-lto-options {{ -O2 -flto -ftree-vectorize }} }
> lto/pr46911_0.f:! { dg-lto-options {{ -O2 -flto -g }} }
> lto/pr47839_0.f90:! { dg-lto-options {{ -g -flto }} }
> move_alloc_13.f90:! { dg-do run}
> structure_constructor_11.f90:! { dg-do run}
> tab_continuation.f:! { dg-warning "Nonconforming tab character in column 1 of line 10" "Nonconforming tab" {target "*-*-*"} 0 }
> tab_continuation.f:! { dg-warning "Nonconforming tab character in column 1 of line 11" "Nonconforming tab" {target "*-*-*"} 0 }
> tab_continuation.f:! { dg-warning "Nonconforming tab character in column 1 of line 8" "Nonconforming tab" {target "*-*-*"} 0 }
> tab_continuation.f:! { dg-warning "Nonconforming tab character in column 1 of line 9" "Nonconforming tab" {target "*-*-*"} 0 }
> vect/vect-2.f90:! { dg-final { scan-tree-dump-times "Alignment of access forced using versioning." 3 "vect" {target { vect_no_align || { { ! vector_alignment_reachable  } && { ! vect_hw_misalign } } } } } }
> vect/vect-3.f90:! { dg-final { scan-tree-dump-times "Alignment of access forced using peeling" 1 "vect" { xfail { vect_no_align || {! vector_alignment_reachable}} } } }
> vect/vect-3.f90:! { dg-final { scan-tree-dump-times "Alignment of access forced using versioning" 1 "vect" { target { {! vect_no_align} && { {! vector_alignment_reachable} && {! vect_hw_misalign} } } } } }
> vect/vect-3.f90:! { dg-final { scan-tree-dump-times "Vectorizing an unaligned access" 1 "vect" { xfail { { vect_no_align } || { ! vector_alignment_reachable} } } } }
> vect/vect-3.f90:! { dg-final { scan-tree-dump-times "Vectorizing an unaligned access" 2 "vect" { target { {! vect_no_align} && { {! vector_alignment_reachable} && {! vect_hw_misalign} } } } } }
> vect/vect-4.f90:! { dg-final { scan-tree-dump-times "Alignment of access forced using peeling" 1 "vect" { xfail { { vect_no_align } || {! vector_alignment_reachable} } } } }
> vect/vect-4.f90:! { dg-final { scan-tree-dump-times "Vectorizing an unaligned access" 1 "vect" { xfail { { vect_no_align } || {! vector_alignment_reachable} } } } }
> vect/vect-4.f90:! { dg-final { scan-tree-dump-times "Vectorizing an unaligned access" 2 "vect" { target { {! vector_alignment_reachable} && {! vect_hw_misalign} } } } }
> vect/vect-5.f90:! { dg-final { scan-tree-dump-times "Alignment of access forced using peeling" 1 "vect" { xfail { vect_no_align || {! vector_alignment_reachable} } } } }
> vect/vect-5.f90:! { dg-final { scan-tree-dump-times "Alignment of access forced using versioning." 1 "vect" { target { {! vector_alignment_reachable} && {! vect_hw_misalign} } } } }
> warning-directive-2.F90:! { dg-message "some warnings being treated as errors" "" {target "*-*-*"} 0 }
>
>
> cheers,
> Manfred
>
>
>
>>>> find gfortran.dg -name "*.[fF]90" -o -name "*.[fF]" | \
>>>> xargs fgrep -w -L 'dg-do' | \
>>>> xargs head -1 -v
>>>>
>>>> and manual inspection of the resulting output results in:
>>>>
>>>> - Typos
>>>>
>>> [...]
>>>>
>>>> - Possibly missing { dg-do run }
>>>>
>>> [...]
>>>
>>> Mind sending patch and changelog to @gcc-patches ?
>>>
>>
>> Here we go.  No failures, but additional passes because of the dg-do run's.  Somebody please take care of it?
>>
>> Harald
>>
>>
>> 2013-01-13  Harald Anlauf <anlauf@gmx.de>
>>
>>      * gfortran.dg/aint_anint_1.f90: Add dg-do run.
>>      * gfortran.dg/bounds_check_4.f90: Likewise.
>>      * gfortran.dg/inquire_10.f90: Likewise.
>>      * gfortran.dg/minloc_3.f90: Likewise.
>>      * gfortran.dg/minlocval_3.f90: Likewise.
>>      * gfortran.dg/module_double_reuse.f90: Likewise.
>>      * gfortran.dg/mvbits_1.f90: Likewise.
>>      * gfortran.dg/oldstyle_1.f90: Likewise.
>>      * gfortran.dg/pr20163-2.f: Likewise.
>>      * gfortran.dg/save_1.f90: Likewise.
>>      * gfortran.dg/scan_1.f90: Likewise.
>>      * gfortran.dg/select_char_1.f90: Likewise.
>>      * gfortran.dg/shape_4.f90: Likewise.
>>      * gfortran.dg/coarray_29_2.f90: Fix dg-do directive.
>>      * gfortran.dg/function_optimize_10.f90: Likewise.
>>      * gfortran.dg/gomp/appendix-a/a.11.2.f90: Likewise.
>>      * gfortran.dg/used_types_17.f90: Likewise.
>>      * gfortran.dg/used_types_18.f90: Likewise.
>>
>
>