* [testsuite] fix ARM test gcc.target/arm/neon-vld1_dupQ.c
@ 2013-01-14 23:02 Janis Johnson
2013-01-15 16:29 ` Janis Johnson
0 siblings, 1 reply; 5+ messages in thread
From: Janis Johnson @ 2013-01-14 23:02 UTC (permalink / raw)
To: gcc-patches; +Cc: christophe.lyon
Test gcc.target/arm/neon-vld1_dupQ.c started failing with r194594, a C
front end change that causes the test to get warnings. The test passes
local variables of type int64x1_t to functions declared with arguments
of type int64_t. This patch casts the values passed to those arguments.
It's possible that the patch invalidates the intent of the test, so I've
copied the test's author.
OK for trunk?
Janis
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [testsuite] fix ARM test gcc.target/arm/neon-vld1_dupQ.c
2013-01-14 23:02 [testsuite] fix ARM test gcc.target/arm/neon-vld1_dupQ.c Janis Johnson
@ 2013-01-15 16:29 ` Janis Johnson
2013-01-17 12:44 ` Christophe Lyon
2013-01-22 10:52 ` Ramana Radhakrishnan
0 siblings, 2 replies; 5+ messages in thread
From: Janis Johnson @ 2013-01-15 16:29 UTC (permalink / raw)
To: janisjo; +Cc: gcc-patches, christophe.lyon
[-- Attachment #1: Type: text/plain, Size: 511 bytes --]
On 01/14/2013 03:04 PM, Janis Johnson wrote:
> Test gcc.target/arm/neon-vld1_dupQ.c started failing with r194594, a C
> front end change that causes the test to get warnings. The test passes
> local variables of type int64x1_t to functions declared with arguments
> of type int64_t. This patch casts the values passed to those arguments.
> It's possible that the patch invalidates the intent of the test, so I've
> copied the test's author.
>
> OK for trunk?
>
> Janis
>
Here's the patch (thanks, Aldy!).
[-- Attachment #2: gcc-20130114-2 --]
[-- Type: text/plain, Size: 774 bytes --]
2013-01-14 Janis Johnson <janisjo@codesourcery.com>
* gcc.target/arm/neon-vld1_dupQ.c: Use types that match function
prototypes.
Index: gcc.target/arm/neon-vld1_dupQ.c
===================================================================
--- gcc.target/arm/neon-vld1_dupQ.c (revision 195178)
+++ gcc.target/arm/neon-vld1_dupQ.c (working copy)
@@ -13,9 +13,9 @@
int64x1_t input[2] = {(int64x1_t)0x0123456776543210LL,
(int64x1_t)0x89abcdeffedcba90LL};
int64x1_t output[2] = {0, 0};
- int64x2_t var = vld1q_dup_s64(input);
+ int64x2_t var = vld1q_dup_s64((int64_t *)input);
- vst1q_s64(output, var);
+ vst1q_s64((int64_t *)output, var);
if (output[0] != (int64x1_t)0x0123456776543210LL)
abort();
if (output[1] != (int64x1_t)0x0123456776543210LL)
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [testsuite] fix ARM test gcc.target/arm/neon-vld1_dupQ.c
2013-01-15 16:29 ` Janis Johnson
@ 2013-01-17 12:44 ` Christophe Lyon
2013-01-22 10:52 ` Ramana Radhakrishnan
1 sibling, 0 replies; 5+ messages in thread
From: Christophe Lyon @ 2013-01-17 12:44 UTC (permalink / raw)
To: janisjo; +Cc: Janis Johnson, gcc-patches
On 15.01.2013 17:31, Janis Johnson wrote:
> On 01/14/2013 03:04 PM, Janis Johnson wrote:
>> Test gcc.target/arm/neon-vld1_dupQ.c started failing with r194594, a C
>> front end change that causes the test to get warnings. The test passes
>> local variables of type int64x1_t to functions declared with arguments
>> of type int64_t. This patch casts the values passed to those arguments.
>> It's possible that the patch invalidates the intent of the test, so I've
>> copied the test's author.
>>
>> OK for trunk?
>>
>> Janis
>>
> Here's the patch (thanks, Aldy!).
It looks OK, altough you could also have changed the type of input and output to int64_t[2] to avoid casts.
Thanks,
Christophe.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [testsuite] fix ARM test gcc.target/arm/neon-vld1_dupQ.c
2013-01-15 16:29 ` Janis Johnson
2013-01-17 12:44 ` Christophe Lyon
@ 2013-01-22 10:52 ` Ramana Radhakrishnan
1 sibling, 0 replies; 5+ messages in thread
From: Ramana Radhakrishnan @ 2013-01-22 10:52 UTC (permalink / raw)
To: janisjo; +Cc: Janis Johnson, gcc-patches, christophe.lyon
On 01/15/13 16:31, Janis Johnson wrote:
> On 01/14/2013 03:04 PM, Janis Johnson wrote:
>> Test gcc.target/arm/neon-vld1_dupQ.c started failing with r194594, a C
>> front end change that causes the test to get warnings. The test passes
>> local variables of type int64x1_t to functions declared with arguments
>> of type int64_t. This patch casts the values passed to those arguments.
>> It's possible that the patch invalidates the intent of the test, so I've
>> copied the test's author.
>>
>> OK for trunk?
>>
>> Janis
>>
>
> Here's the patch (thanks, Aldy!).
>
This is OK.
Ramana
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [testsuite] fix ARM test gcc.target/arm/neon-vld1_dupQ.c
@ 2013-01-16 13:46 Nick Clifton
0 siblings, 0 replies; 5+ messages in thread
From: Nick Clifton @ 2013-01-16 13:46 UTC (permalink / raw)
To: janis_johnson; +Cc: gcc-patches
Hi Janis,
> 2013-01-14 Janis Johnson <janisjo@codesourcery.com>
>
> * gcc.target/arm/neon-vld1_dupQ.c: Use types that match function
> prototypes.
Approved - please apply.
Cheers
Nick
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-01-22 10:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-14 23:02 [testsuite] fix ARM test gcc.target/arm/neon-vld1_dupQ.c Janis Johnson
2013-01-15 16:29 ` Janis Johnson
2013-01-17 12:44 ` Christophe Lyon
2013-01-22 10:52 ` Ramana Radhakrishnan
2013-01-16 13:46 Nick Clifton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).