From: Janis Johnson <janis_johnson@mentor.com>
To: <janisjo@codesourcery.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
<christophe.lyon@st.com>
Subject: Re: [testsuite] fix ARM test gcc.target/arm/neon-vld1_dupQ.c
Date: Tue, 15 Jan 2013 16:29:00 -0000 [thread overview]
Message-ID: <50F5846E.6060102@mentor.com> (raw)
In-Reply-To: <50F48EF9.1010206@mentor.com>
[-- Attachment #1: Type: text/plain, Size: 511 bytes --]
On 01/14/2013 03:04 PM, Janis Johnson wrote:
> Test gcc.target/arm/neon-vld1_dupQ.c started failing with r194594, a C
> front end change that causes the test to get warnings. The test passes
> local variables of type int64x1_t to functions declared with arguments
> of type int64_t. This patch casts the values passed to those arguments.
> It's possible that the patch invalidates the intent of the test, so I've
> copied the test's author.
>
> OK for trunk?
>
> Janis
>
Here's the patch (thanks, Aldy!).
[-- Attachment #2: gcc-20130114-2 --]
[-- Type: text/plain, Size: 774 bytes --]
2013-01-14 Janis Johnson <janisjo@codesourcery.com>
* gcc.target/arm/neon-vld1_dupQ.c: Use types that match function
prototypes.
Index: gcc.target/arm/neon-vld1_dupQ.c
===================================================================
--- gcc.target/arm/neon-vld1_dupQ.c (revision 195178)
+++ gcc.target/arm/neon-vld1_dupQ.c (working copy)
@@ -13,9 +13,9 @@
int64x1_t input[2] = {(int64x1_t)0x0123456776543210LL,
(int64x1_t)0x89abcdeffedcba90LL};
int64x1_t output[2] = {0, 0};
- int64x2_t var = vld1q_dup_s64(input);
+ int64x2_t var = vld1q_dup_s64((int64_t *)input);
- vst1q_s64(output, var);
+ vst1q_s64((int64_t *)output, var);
if (output[0] != (int64x1_t)0x0123456776543210LL)
abort();
if (output[1] != (int64x1_t)0x0123456776543210LL)
next prev parent reply other threads:[~2013-01-15 16:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 23:02 Janis Johnson
2013-01-15 16:29 ` Janis Johnson [this message]
2013-01-17 12:44 ` Christophe Lyon
2013-01-22 10:52 ` Ramana Radhakrishnan
2013-01-16 13:46 Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F5846E.6060102@mentor.com \
--to=janis_johnson@mentor.com \
--cc=christophe.lyon@st.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=janisjo@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).