From: Janis Johnson <janis_johnson@mentor.com>
To: Nick Clifton <nickc@redhat.com>
Cc: <gcc-patches@gcc.gnu.org>, <rearnshaw@cambridge.arm.com>
Subject: Re: PING: gcc.target/arm: skip 5 tests for flag conflicts
Date: Wed, 16 Jan 2013 23:47:00 -0000 [thread overview]
Message-ID: <50F73C8B.6040700@mentor.com> (raw)
In-Reply-To: <871udl5k5c.fsf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 805 bytes --]
On 01/16/2013 05:31 AM, Nick Clifton wrote:
> Hi Janis,
>
>> Back in September I submitted a patch to fix five ARM tests in
>> <http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01515.html>.
>> You responded in < http://gcc.gnu.org/ml/gcc-patches/2012-10/msg00972.html>
>> and I answered your questions in a reply.
>
> I believe that Richard's main point was that the skips that you were
> adding to the tests meant that they would not be run for valid
> command line options.
Now I get it. This version is more selective about which multilibs
are skipped. I tested it by using multilib test flags for all valid
values for -march, with and without -mthumb as appropriate for the
arch. The ones that are now skipped are the ones that used to fail
with complaints from the compiler.
Is this OK?
Janis
[-- Attachment #2: gcc-20130116-2 --]
[-- Type: text/plain, Size: 3561 bytes --]
2013-01-16 Janis Johnson <janisjo@codesourcery.com>
* gcc.target/arm/pr40887.c: Require at least armv5.
* gcc.target/arm/pr51835.c: Avoid conflicts with multilib flags.
* gcc.target/arm/pr51915.c: Likewise.
* gcc.target/arm/pr52006.c: Likewise.
* gcc.target/arm/pr53187.c: Likewise.
Index: src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr40887.c
===================================================================
--- src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr40887.c (revision 195216)
+++ src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr40887.c (working copy)
@@ -1,3 +1,4 @@
+/* { dg-skip-if "need at least armv5" { *-*-* } { "-march=armv[234]*" } { "" } } */
/* { dg-options "-O2 -march=armv5te" } */
/* { dg-final { scan-assembler "blx" } } */
Index: src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr51835.c
===================================================================
--- src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr51835.c (revision 195216)
+++ src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr51835.c (working copy)
@@ -1,6 +1,8 @@
/* { dg-do compile } */
-/* { dg-options "-O2 -mfloat-abi=hard -mfpu=fpv4-sp-d16" } */
-/* { dg-require-effective-target arm_thumb2_ok } */
+/* { dg-skip-if "no support for hard-float VFP ABI" { arm_thumb1 } { "-march=*" } { "" } } */
+/* { dg-skip-if "do not override -mfloat-abi" { *-*-* } { "-mfloat-abi=*" } { "-mfloat-abi=hard" } } */
+/* { dg-skip-if "avoid conflicting -mfpu" { *-*-* } { "-mfpu=*" } { "-mfpu=fpv4-sp-d16" "-mfpu=vfpv3xd" "-mfpu=vfpv3xd-fp16" } } */
+/* { dg-options "-O2 -march=armv7-a -mfloat-abi=hard -mfpu=fpv4-sp-d16" } */
int func1 (double d)
{
Index: src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr51915.c
===================================================================
--- src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr51915.c (revision 195216)
+++ src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr51915.c (working copy)
@@ -1,5 +1,7 @@
/* PR target/51915 */
/* { dg-do compile } */
+/* { dg-skip-if "no support for hard-float VFP ABI" { arm_thumb1 } { "-march=*" } { "" } } */
+/* { dg-skip-if "do not override -mfloat-abi" { *-*-* } { "-mfloat-abi=*" } { "-mfloat-abi=hard" } } */
/* { dg-options "-march=armv7-a -mfloat-abi=hard -O2" } */
struct S { int s1; void *s2; };
Index: src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr52006.c
===================================================================
--- src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr52006.c (revision 195216)
+++ src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr52006.c (working copy)
@@ -1,5 +1,7 @@
/* PR target/52006 */
/* { dg-do compile } */
+/* { dg-skip-if "avoid conflicts with multilib flags" { *-*-* } { "-mfloat-abi=*" } { "-mfloat-abi=hard" } } */
+/* { dg-skip-if "no support for hard-float VFP ABI" { arm_thumb1 } { "-march=*" } { "" } } */
/* { dg-options "-march=armv7-a -mfloat-abi=hard -O2 -fPIC" } */
unsigned long a;
Index: src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr53187.c
===================================================================
--- src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr53187.c (revision 195216)
+++ src/gcc-mainline/gcc/testsuite/gcc.target/arm/pr53187.c (working copy)
@@ -1,5 +1,7 @@
/* PR target/53187 */
/* { dg-do compile } */
+/* { dg-skip-if "no support for hard-float VFP ABI" { arm_thumb1 } { "-march=*" } { "" } } */
+/* { dg-skip-if "do not override -mfloat-abi" { *-*-* } { "-mfloat-abi=*" } { "-mfloat-abi=hard" } } */
/* { dg-options "-march=armv7-a -mfloat-abi=hard -O2" } */
void bar (int);
next prev parent reply other threads:[~2013-01-16 23:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 13:35 Nick Clifton
2013-01-16 23:47 ` Janis Johnson [this message]
2013-01-17 15:04 ` nick clifton
-- strict thread matches above, loose matches on Subject: below --
2013-01-14 21:21 Janis Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F73C8B.6040700@mentor.com \
--to=janis_johnson@mentor.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=janisjo@codesourcery.com \
--cc=nickc@redhat.com \
--cc=rearnshaw@cambridge.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).