public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@redhat.com>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: ubizjak@gmail.com, Aldy Hernandez <aldyh@redhat.com>,
	       gcc-patches@gcc.gnu.org
Subject: Re: [PR55547] fix alias regression on alpha on misaligned symbols
Date: Thu, 17 Jan 2013 17:05:00 -0000	[thread overview]
Message-ID: <50F82F3F.5050901@redhat.com> (raw)
In-Reply-To: <ortxqg4jma.fsf@livre.localdomain>

On 2013-01-16 18:40, Alexandre Oliva wrote:
>> That said, I question the change of <= to == 0.  If negative, we don't
>> know how much overlap there is as far as I can see.
>
> Why not?  Since the addresses are constants, and the negative sizes are
> just the adjusted sizes, negated to indicate they were conservatively
> lengthened by an alignment operation...

Oh, right.

>> This hunk is not needed, as we begin by eliminating <= 0.  So the abs
>> is certain to do nothing.
>
> The function I'll introduce to keep the expressions the same will have
> the abs and I'll use it here, but you're right that after testing for
> negative sizes they abses won't make much of a difference.

Sure.


r~

  reply	other threads:[~2013-01-17 17:05 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <50F582CE.3090201@redhat.com>
     [not found] ` <50F585DB.2020706@redhat.com>
2013-01-16  4:30   ` [PR55547] fix alias regression on alpha on misaligned symbols (was: Re: do you have time to review this alpha P1 patch?) Alexandre Oliva
2013-01-16  7:34     ` Uros Bizjak
2013-01-16 19:35       ` Uros Bizjak
2013-01-18 11:13         ` [PR55547] fix alias regression on alpha on misaligned symbols Alexandre Oliva
2013-01-16 19:54     ` Richard Henderson
2013-01-17  2:41       ` Alexandre Oliva
2013-01-17 17:05         ` Richard Henderson [this message]
2013-01-17  4:16       ` Alexandre Oliva
2013-01-17 17:07         ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F82F3F.5050901@redhat.com \
    --to=rth@redhat.com \
    --cc=aldyh@redhat.com \
    --cc=aoliva@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).