From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29022 invoked by alias); 19 Jan 2013 05:16:18 -0000 Received: (qmail 29005 invoked by uid 22791); 19 Jan 2013 05:16:17 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 19 Jan 2013 05:16:11 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0J5G0QB011903 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 19 Jan 2013 00:16:05 -0500 Received: from [10.3.113.26] (ovpn-113-26.phx2.redhat.com [10.3.113.26]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0J5FxN8020558; Sat, 19 Jan 2013 00:15:59 -0500 Message-ID: <50FA2C0E.9010206@redhat.com> Date: Sat, 19 Jan 2013 05:16:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Jack Howarth CC: gcc-patches List , Dominique Dhumieres Subject: Re: C++ PATCH for target/54908 (thread_local vs emutls) References: <507BBBDE.1090909@redhat.com> <50F9CCAE.7070409@redhat.com> <20130119022016.GA28778@bromo.med.uc.edu> In-Reply-To: <20130119022016.GA28778@bromo.med.uc.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg00996.txt.bz2 On 01/18/2013 09:20 PM, Jack Howarth wrote: > The proposed patch eliminates all of the previous failures from PR54908 > at both -m32/-m64 on x86_64-apple-darwin12 but seems to introduce a new set of > failures... > > FAIL: g++.dg/tls/thread_local-wrap3.C scan-assembler _ZTH1i > FAIL: g++.dg/gomp/tls-wrap3.C -std=c++98 scan-assembler _ZTH1i > FAIL: g++.dg/gomp/tls-wrap3.C -std=c++11 scan-assembler _ZTH1i Ah, yes; those are specifically testing for the aliases that we can't generate on darwin. I'll add dg-require-alias to those tests. Thanks for the testing. > Recompiling the testcase with -fextern-tls-init doesn't produce the missing _ZTH1i. Hmm, compiling with -fextern-tls-init should give an error for you. Doesn't it? Jason