From: Jason Merrill <jason@redhat.com>
To: Patrick Palka <ppalka@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] c++: mangling template-id of unknown template [PR110524]
Date: Fri, 14 Jul 2023 18:24:30 -0400 [thread overview]
Message-ID: <50e83bb2-ca98-fd31-09f4-4c0e41feaf0a@redhat.com> (raw)
In-Reply-To: <20230713132017.3289546-1-ppalka@redhat.com>
On 7/13/23 09:20, Patrick Palka wrote:
> Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK
> for trunk and perhaps 13?
OK for both.
> -- >8 --
>
> This fixes a crash when mangling an ADL-enabled call to a template-id
> naming an unknown template (as per P0846R0).
>
> PR c++/110524
>
> gcc/cp/ChangeLog:
>
> * mangle.cc (write_expression): Handle TEMPLATE_ID_EXPR
> whose template is already an IDENTIFIER_NODE.
>
> gcc/testsuite/ChangeLog:
>
> * g++.dg/cpp2a/fn-template26.C: New test.
> ---
> gcc/cp/mangle.cc | 3 ++-
> gcc/testsuite/g++.dg/cpp2a/fn-template26.C | 16 ++++++++++++++++
> 2 files changed, 18 insertions(+), 1 deletion(-)
> create mode 100644 gcc/testsuite/g++.dg/cpp2a/fn-template26.C
>
> diff --git a/gcc/cp/mangle.cc b/gcc/cp/mangle.cc
> index 7dab4e62bc9..bef0fda6d22 100644
> --- a/gcc/cp/mangle.cc
> +++ b/gcc/cp/mangle.cc
> @@ -3312,7 +3312,8 @@ write_expression (tree expr)
> else if (TREE_CODE (expr) == TEMPLATE_ID_EXPR)
> {
> tree fn = TREE_OPERAND (expr, 0);
> - fn = OVL_NAME (fn);
> + if (!identifier_p (fn))
> + fn = OVL_NAME (fn);
> if (IDENTIFIER_ANY_OP_P (fn))
> write_string ("on");
> write_unqualified_id (fn);
> diff --git a/gcc/testsuite/g++.dg/cpp2a/fn-template26.C b/gcc/testsuite/g++.dg/cpp2a/fn-template26.C
> new file mode 100644
> index 00000000000..d4a17eb9bd1
> --- /dev/null
> +++ b/gcc/testsuite/g++.dg/cpp2a/fn-template26.C
> @@ -0,0 +1,16 @@
> +// PR c++/110524
> +// { dg-do compile { target c++20 } }
> +
> +template<class T>
> +auto f(T t) -> decltype(g<T>(t));
> +
> +namespace N {
> + struct A { };
> + template<class T> void g(T);
> +};
> +
> +int main() {
> + f(N::A{});
> +}
> +
> +// { dg-final { scan-assembler "_Z1fIN1N1AEEDTcl1gIT_Efp_EES2_" } }
prev parent reply other threads:[~2023-07-14 22:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 13:20 Patrick Palka
2023-07-14 22:24 ` Jason Merrill [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50e83bb2-ca98-fd31-09f4-4c0e41feaf0a@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).