From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by sourceware.org (Postfix) with ESMTPS id 166573858D28; Tue, 1 Aug 2023 19:06:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 166573858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=fastmail.fm Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fastmail.fm Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B1D565C0138; Tue, 1 Aug 2023 15:06:33 -0400 (EDT) Received: from imap45 ([10.202.2.95]) by compute1.internal (MEProxy); Tue, 01 Aug 2023 15:06:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1690916793; x=1691003193; bh=bv MfuoJZFsFRKFfFhvBzWHLCzXb0GmDoRE43yFr9T3Y=; b=SH25IXl05Xq3VKSLS8 YJZOMRmUPK2WxSxVHvrFN+KQIsE1tE+FVHpa/qe4lOYYONMdr9T7v3fbljdaGj8P NiDw8iyFnf270nXEoc9kgUeBlq6G98eu4x1UZyp2tPPBdd7O7MBkX8JJE4Eckvw7 QN5MrYKkZ/6mY3rsivyaZg/CpyqdwnZZ/WX/tCEFH8MmQnbyeG9bAxJRbbwPg7F2 kTwcmyUmpglggDEiws7n+l0f24wbqXMTudVFbqo2mZkhE32jBbwtohnqn2gDTz49 +skkTLUQv0NmxQTTOu49ekdOGJhxhwt6Eo0I0kzmVMY3Le0/MZb9Vo3l0Z3Tf4By ll7w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1690916793; x=1691003193; bh=bvMfuoJZFsFRK FfFhvBzWHLCzXb0GmDoRE43yFr9T3Y=; b=Dbv2e0YtU6DuN6KprVZQGE5ynFFfx p4sfSDh0NDVLG1zjxL6hq5/Bippg06z10KVJwYNOs3HVcsopQf3j9LD3ScLr6Y78 688JlS2pkf+TtaR8qBDeAwgQsbTGttV+N6cvGE3qyl98cSE51JkaL/8NPKQuaQHr 3AuUnxUsFAM0fhe39QviOQa3rfBHdOhOQSLLWeX9HODC0LuVdfD/LlAS597o8rpR uW5BmrObxUooPplBirwpB8bJkAfez1Oj5ovSojo0hI3blfWl7RYrNDT6/Fe/JYeB mq1/r2vsTZr4nklKhohx7VBheVT3ARJF6CWdHlGSI+wju9StigtrUNSAw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrjeeigddufedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedfpfgr thhhrghnrggvlhcupfgvrhhouggvfdcuoehntghnpghgtggtuddtsehfrghsthhmrghilh drfhhmqeenucggtffrrghtthgvrhhnpeetudegffekiefggfetveeglefgtdelhfduvdei hfeuiedtudfhjeffteduudegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehntghnpghgtggtuddtsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Feedback-ID: i49f641f0:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 5E442272007B; Tue, 1 Aug 2023 15:06:33 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-592-ga9d4a09b4b-fm-defalarms-20230725.001-ga9d4a09b Mime-Version: 1.0 Message-Id: <50eeda11-58ee-4ac7-bc74-1ced8d07914d@app.fastmail.com> In-Reply-To: <9c79db70-94a6-58e7-96f3-d7c60a9d5893@suse.com> References: <9c79db70-94a6-58e7-96f3-d7c60a9d5893@suse.com> Date: Tue, 01 Aug 2023 15:06:13 -0400 From: "Nathanael Nerode" To: "Jan Beulich" , gcc-patches@gcc.gnu.org Cc: "bonzini@gnu.org" , neroden@gcc.gnu.org, aoliva@gcc.gnu.org, Ralf.Wildenhues@gmx.de Subject: Re: [PATCH RESEND] libatomic: drop redundant all-multi command Content-Type: text/plain X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I'm afraid I don't understand this part of the code well, and I've really been away from GCC work for years, and I'm not sure what tests should be run to verify that this is working, so I don't feel comfortable approving it by myself. It looks right though. On Tue, Aug 1, 2023, at 1:55 AM, Jan Beulich wrote: > ./multilib.am already specifies this same command, and make warns about > the earlier one being ignored when seeing the later one. All that needs > retaining to still satisfy the preceding comment is the extra > dependency. > > libatomic/ > > * Makefile.am (all-multi): Drop commands. > * Makefile.in: Update accordingly. > --- > While originally sent over a year ago and pinged subsequently, I can't > quite view changes like this as "trivial" ... > > --- a/libatomic/Makefile.am > +++ b/libatomic/Makefile.am > @@ -149,12 +149,11 @@ endif > libatomic_convenience_la_SOURCES = $(libatomic_la_SOURCES) > libatomic_convenience_la_LIBADD = $(libatomic_la_LIBADD) > > -# Override the automake generated all-multi rule to guarantee that all-multi > +# Amend the automake generated all-multi rule to guarantee that all-multi > # is not run in parallel with the %_.lo rules which generate $(DEPDIR)/*.Ppo > # makefile fragments to avoid broken *.Ppo getting included into the Makefile > # when it is reloaded during the build of all-multi. > all-multi: $(libatomic_la_LIBADD) > - $(MULTIDO) $(AM_MAKEFLAGS) DO=all multi-do # $(MAKE) > > # target overrides > -include $(tmake_file) > --- a/libatomic/Makefile.in > +++ b/libatomic/Makefile.in > @@ -892,12 +892,11 @@ vpath % $(strip $(search_path)) > %_.lo: Makefile > $(LTCOMPILE) $(M_DEPS) $(M_SIZE) $(M_IFUNC) -c -o $@ $(M_SRC) > > -# Override the automake generated all-multi rule to guarantee that all-multi > +# Amend the automake generated all-multi rule to guarantee that all-multi > # is not run in parallel with the %_.lo rules which generate $(DEPDIR)/*.Ppo > # makefile fragments to avoid broken *.Ppo getting included into the Makefile > # when it is reloaded during the build of all-multi. > all-multi: $(libatomic_la_LIBADD) > - $(MULTIDO) $(AM_MAKEFLAGS) DO=all multi-do # $(MAKE) > > # target overrides > -include $(tmake_file)