From: Richard Biener <rguenther@suse.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Jeff Law <jeffreyalaw@gmail.com>,
Gerald Pfeifer <gerald@pfeifer.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libsanitizer: Fix bootstrap on FreeBSD [PR102675]
Date: Thu, 18 Nov 2021 10:00:20 +0100 (CET) [thread overview]
Message-ID: <50n989n-srr0-pnsr-419p-184n3n76sqp0@fhfr.qr> (raw)
In-Reply-To: <20211117130913.GL2710@tucnak>
On Wed, 17 Nov 2021, Jakub Jelinek wrote:
> On Mon, Nov 08, 2021 at 08:50:41AM +0100, Gerald Pfeifer wrote:
> > This is the first part I committed on Friday, the second will
> > follow today.
>
> Here is an alternative to the patch changing a file imported from
> compiler-rt upstream, so that we don't need to cary a local patch for that
> particular problem.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux (verified that
> -DUSE_SYSTEM_MD5 is passed only when compiling
> sanitizer_platform_limits_freebsd.cpp) and Gerald in the PR said
> it passed bootstrap on FreeBSD as well.
>
> Ok for trunk?
OK.
> 2021-11-17 Jakub Jelinek <jakub@redhat.com>
>
> PR bootstrap/102675
> * sanitizer_common/Makefile.am: Use -DUSE_SYSTEM_MD5 in AM_CXXFLAGS
> of sanitizer_platform_limits_freebsd.cpp.
> * sanitizer_common/Makefile.in: Regenerated.
>
> --- libsanitizer/sanitizer_common/Makefile.am.jj 2021-11-05 00:43:22.647623646 +0100
> +++ libsanitizer/sanitizer_common/Makefile.am 2021-11-16 12:29:58.574930436 +0100
> @@ -17,6 +17,7 @@ AM_CXXFLAGS += -DSANITIZER_LIBBACKTRACE
> endif
> AM_CCASFLAGS = $(EXTRA_ASFLAGS)
> ACLOCAL_AMFLAGS = -I m4
> +sanitizer_platform_limits_freebsd.lo: AM_CXXFLAGS += -DUSE_SYSTEM_MD5
>
> noinst_LTLIBRARIES = libsanitizer_common.la
>
> --- libsanitizer/sanitizer_common/Makefile.in.jj 2021-11-05 00:43:22.647623646 +0100
> +++ libsanitizer/sanitizer_common/Makefile.in 2021-11-16 12:30:58.611088913 +0100
> @@ -796,6 +796,7 @@ uninstall-am:
>
> .PRECIOUS: Makefile
>
> +sanitizer_platform_limits_freebsd.lo: AM_CXXFLAGS += -DUSE_SYSTEM_MD5
>
> # Tell versions [3.59,3.63) of GNU make to not export all variables.
> # Otherwise a system limit (for SysV at least) may be exceeded.
>
> Jakub
>
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg,
Germany; GF: Ivo Totev; HRB 36809 (AG Nuernberg)
prev parent reply other threads:[~2021-11-18 9:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-30 20:53 [PATCH] libsanitizer: Disable libbacktrace on sanitizer_platform_limits_freebsd.cpp H.J. Lu
2021-11-02 9:14 ` Richard Biener
2021-11-02 12:02 ` H.J. Lu
2021-11-02 12:11 ` Jakub Jelinek
2021-11-02 12:26 ` H.J. Lu
2021-11-04 5:43 ` Gerald Pfeifer
2021-11-04 8:19 ` Jakub Jelinek
2021-11-04 12:30 ` H.J. Lu
2021-11-08 7:50 ` Gerald Pfeifer
2021-11-17 13:09 ` [PATCH] libsanitizer: Fix bootstrap on FreeBSD [PR102675] Jakub Jelinek
2021-11-18 9:00 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50n989n-srr0-pnsr-419p-184n3n76sqp0@fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=gerald@pfeifer.com \
--cc=jakub@redhat.com \
--cc=jeffreyalaw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).