From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id DBC0A3894C17 for ; Mon, 5 Dec 2022 08:43:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DBC0A3894C17 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B575k6O018763; Mon, 5 Dec 2022 08:43:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=ZE6wKBaf1ou+eUulYz1BvMu8JJHHkSfsVzrEtjYV8OA=; b=Qtmz/ociZCWHDWdSjKz02f17BeWsTBmvU2NEbI/3QunzIHYWLdbodp4jzCmCyOePHYYU 9vc1DlC7L5NUE14BSYTK7bhjPCjFvf4UhsDIzql8BP/x7nJV21PiNWhC4EljMLQbP3bF rOFnVbOvindTVVXL2rBu1YCvviD8LZEIi6/M/lAbj+cb41cmRG8mkdQ4taR4OtWxdGRs CVYYPWPKkUjSefyxYL+GadhzM8RGyZtdeaAsbUQdc44ccJhNfyA25o1xf48L1I+rd5Uv XVf3a8koEGSDspbVbsiQGdnHVHn5OzhXNidyesBRIaGbetbhZeN3i7zHmV/BgGwlscz5 og== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3m8g8sw1bg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Dec 2022 08:43:56 +0000 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2B53qaYH000812; Mon, 5 Dec 2022 08:43:55 GMT Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3m8g8sw1au-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Dec 2022 08:43:55 +0000 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2B58Z5sp005862; Mon, 5 Dec 2022 08:43:53 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma06fra.de.ibm.com with ESMTP id 3m7wqhstwf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Dec 2022 08:43:53 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2B58bAaS11928162 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Dec 2022 08:37:10 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 119A7A404D; Mon, 5 Dec 2022 08:43:50 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 973C1A4051; Mon, 5 Dec 2022 08:43:47 +0000 (GMT) Received: from [9.171.78.147] (unknown [9.171.78.147]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 5 Dec 2022 08:43:47 +0000 (GMT) Message-ID: <510a5367-def4-22eb-4a47-e81d1b38f5c9@linux.ibm.com> Date: Mon, 5 Dec 2022 16:43:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2] Return a NULL rtx when targets don't support cbranchcc4 or predicate check fails in prepare_cmp_insn Content-Language: en-US To: Richard Biener Cc: gcc-patches , Segher Boessenkool , David , "Kewen.Lin" , Peter Bergner References: <905c34de-6333-1021-05e6-942922918b18@linux.ibm.com> From: HAO CHEN GUI In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: qrZ4qdvKvbsl4fCtKSmIszkz4hClgMyR X-Proofpoint-GUID: 6mi752kcKH98jLtTWQZroF6lO_o2kIPV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-05_01,2022-12-01_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 mlxlogscore=999 lowpriorityscore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212050067 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Richard, 在 2022/12/5 15:31, Richard Biener 写道: > I wonder if you have a testcase you can add showing this change is > worthwhile and > fixes a bug? I want to enable cbranchcc4 on rs6000. But not all sub CCmode is supported on rs6000. So the predicate check(assert) fails and it hits ICE. I drafted two patches. This one is for the generic code, and another is for rs6000. If this one is committed, cbranchcc4 can be enabled on rs6000. Then I can create a testcase and let the predicate check fail. Right now I can't write a testcase for it as it never reaches the failure path. Thanks a lot Gui Haochen