From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by sourceware.org (Postfix) with ESMTPS id 16EBC3858CDB for ; Mon, 26 Feb 2024 19:54:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 16EBC3858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=baylibre.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 16EBC3858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708977297; cv=none; b=A4Fl6LWJlMOJQKI9CorHflfsp0IVmIN1I72lb/fhCgl1ytNAoJjEwLB3LNite4ZmAJ+/skQ4GI3VeRoZw7deJv6OWczotxSws7WlXivytIbf74Rj0vzoz2E6wTm6ddKn4aEPnw+vdoHPPB8fsj29mj6OJhVWFNrzOz67GYiWPUM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708977297; c=relaxed/simple; bh=8GC7doiCgq4OvGOa2Ljeg23MxDVORDejkOA0gsPOhss=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=x3mT0zSvNehncbrwEcEYm0i1PdnZX9nOMVoEI0wSQGNuTTYK8FYzyC7j3f+ntVGCCn4lCUYtIH75y83g8avamEDMKFN4yIsnBlkbuYi7RkHRdDuhsO/UaNGvSKrMV5qY1dr3t2aO6pKMB9OHrPWt5TAJiuKWNjoijWC6uGWaGdY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12a.google.com with SMTP id e9e14a558f8ab-36519980c04so8303595ab.3 for ; Mon, 26 Feb 2024 11:54:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1708977294; x=1709582094; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BXBmSI95m0P/24VkX9ABrF350kW8z36+SfctcP5TuN8=; b=x5rwuoEEzea3hTadD+X0QZ8c0ztROMq7Tu1Jiuv9aaBsOskjOLMu+u3jbSmX6kL/d7 bO1QFuNCW1yfwQDEteRJ1s9Q3UGeSNR1xqWYWBgZokrLODpNDzXiYfFeacRo+/7hOzGM IcqOPEliTwqgjbP6PMN78xdczDxazCCc2YvEkTkMYpNGWw5lGUEjl0qODLkdWhARfMh0 07dqJ82KlmDBkap09CR8lFUodThneSUoX0lgV0okaLwh9+wkJgoHdV4ij8EDEmua7/i6 3EXPKBareM+RzAVoTIbCZ8vZDef+7XTWxDYv2jpVz4CqSVTZEZcw/M0vcahgw+gntL3r vI/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708977294; x=1709582094; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BXBmSI95m0P/24VkX9ABrF350kW8z36+SfctcP5TuN8=; b=ZQFo0X4uHfWRFdglvwy1TuFjs4O6t1zSWbXR3T+A9h/Memhaj/0brqWAPJH//qmcbe NldM4atXLS/5hYhYsYFkJxbX5wB7xk/H7Ao69l55JsQS2lbhcOit8rlLskIdg2d3B70e McH19yZuDZCYp7uA0D+pmtEvH641RfNqO25Yts/jikgmVis2WGWvvx1DszIo8pXqI/iJ YzUhKAian81bddLIDLIUjpyidHvv8CDUZb44lcJqy2m4QrDqjisFSbyr2aCzFrkqZzl+ vZjoaez6fRX4e6HQjE1vJZuXVYW+QrgSBbf7FzIcQS+ZVxqPa4Ingc7mvQDhbEmAB+Ey oAKQ== X-Forwarded-Encrypted: i=1; AJvYcCWJb/TNlGvc0YD7VSfVlUuBFKofxY5fSIQNdCWiel/ENzhSJV94mh/iJizh4QtABUVWxTsEWDvjVM+vnP5w7yHd1ESvnTLPRQ== X-Gm-Message-State: AOJu0YwxrWYudF9fGCrNSw9dtRkaPBRcvg1mg7WX2e5f07fEFjFdMUdY x9qslXC9DSmoTJWDWDhhQco0g6JNIJtZ7zOpWSxST4VfpqjJqgiN7Rvq+ySeTkU= X-Google-Smtp-Source: AGHT+IFGWIGLsulV8Z4T0YxKl2fDmZ/n0G4G8bs8hq/D0qmDhk5ABeteWmNiyfm2NgjfGzexneFqdA== X-Received: by 2002:a05:6e02:216a:b0:365:259b:711e with SMTP id s10-20020a056e02216a00b00365259b711emr9884375ilv.5.1708977294312; Mon, 26 Feb 2024 11:54:54 -0800 (PST) Received: from ?IPV6:2601:281:d901:5620:c72c:8e75:365:9a7? ([2601:281:d901:5620:c72c:8e75:365:9a7]) by smtp.gmail.com with ESMTPSA id r3-20020a92c503000000b00363c8049f30sm1689256ilg.50.2024.02.26.11.54.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Feb 2024 11:54:54 -0800 (PST) Message-ID: <5111cd69-7de4-429e-94db-21612031e54f@baylibre.com> Date: Mon, 26 Feb 2024 12:54:52 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 RESEND] C, ObjC: Add -Wunterminated-string-initialization Content-Language: en-US To: Joseph Myers , Alejandro Colomar Cc: Mike Stump , GCC Patches References: <20240206104529.8347-1-alx@kernel.org> <10AB5F4B-A27B-4798-9029-626A8B69DA6D@comcast.net> <60699168-584-3155-a463-4811af5d33fa@redhat.com> From: Sandra Loosemore In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/26/24 09:19, Joseph Myers wrote: > On Mon, 26 Feb 2024, Alejandro Colomar wrote: > >>> The idea seems reasonable, but the patch needs documentation for the new >>> option in invoke.texi. >> >> Thanks! Will do. >> >> I don't see an obvious order in that file. Where would you put the >> option? Do you want me to sort(1) it first, and then insert the new >> option in alphabetic order? > > Sandra might have a better idea of how the warning options ought to be > ordered in the manual. (Obviously, don't mix reordering with any content > changes.) Please don't blindly sort the options sections of the manual. They've typically been organized to present general options first (things like -Wpedantic in the warning options section, or -g or -o in the debugging and optimization optimization sections), then more specialized flags for controlling specific individual behaviors. We could do a better job of keeping the latter sublists alphabetized, but in some cases we have also grouped documentation for related options together even if they are not alphabetical, but that needs some manual review and decision-making and should not be mixed with adding new content. We do try to keep the lists in the "Option Summary" section alphabetized except for the general options listed first, though. As far as where to put documentation for new options, I'd say that you should put it in alphabetical order in the appropriate section, unless there is good reason to put it somewhere else, or the alphabetization of the whole section is so messed-up you can't figure out where it should go (putting it at the end is OK in that case, as opposed to some other random location in the list). Remember to add the matching entry in the appropriate "Option Summary" list, and for this option IIUC you also need to add it to the lists of other options enabled by -Wextra and -Wc++-compat. Are we still accepting patches to add new options in stage 4, or is this a stage 1 item? -Sandra