From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2328 invoked by alias); 6 Feb 2013 09:57:20 -0000 Received: (qmail 2319 invoked by uid 22791); 6 Feb 2013 09:57:19 -0000 X-SWARE-Spam-Status: No, hits=-3.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Feb 2013 09:57:11 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Wed, 06 Feb 2013 09:57:07 +0000 Received: from [10.1.69.70] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Wed, 6 Feb 2013 09:57:04 +0000 Message-ID: <511228F0.20300@arm.com> Date: Wed, 06 Feb 2013 09:57:00 -0000 From: Ramana Radhakrishnan Reply-To: ramrad01@arm.com User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: Kyrylo Tkachov CC: "gcc-patches@gcc.gnu.org" , Richard Earnshaw Subject: Re: [PATCH][ARM][1/3] Add vectorization support for rounding functions References: <002201cddd24$46f624f0$d4e26ed0$@tkachov@arm.com> In-Reply-To: <002201cddd24$46f624f0$d4e26ed0$@tkachov@arm.com> X-MC-Unique: 113020609570703101 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-02/txt/msg00204.txt.bz2 On 12/18/12 13:33, Kyrylo Tkachov wrote: > Hi all, > > This patch does some refactoring by moving the definitions of the NEON > builtins to a separate file (arm_neon_builtins.def) and includes that when > initialising the neon_builtin_data array and also during > the definition of enum arm_builtins (with appropriate redefinitions of the > VAR* macros). This allows us to have symbolic names for the neon builtins > that allows us to look up their declaration in > arm_builtin_decls. This is needed for vectorisation support in the next > patch. The ARM_BUILTIN_NEON_BASE constant which was defined as part of the > arm_builtins enum is now defined as a macro, since > various functions that deal with the initialisation and expansion of > builtins use it. > > No regressions on arm-none-eabi with model. > > Ok for trunk? > > Thanks, > Kyrill > > > gcc/ChangeLog > > 2012-12-18 Kyrylo Tkachov > > * config/arm/arm_neon_builtins.def: New file. > * config/arm/arm.c (neon_builtin_data): Move contents to > arm_neon_builtins.def. > (enum arm_builtins): Include neon builtin definitions. > (ARM_BUILTIN_NEON_BASE): Move from enum to macro. > arm.o in t-arm needs to depend on this new file. Otherwise OK for stage1 . regards, Ramana