From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 63EBC3835825 for ; Wed, 28 Jul 2021 11:44:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 63EBC3835825 Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-588-ewv5ga9iNu2NKxC2kvTomw-1; Wed, 28 Jul 2021 07:44:06 -0400 X-MC-Unique: ewv5ga9iNu2NKxC2kvTomw-1 Received: by mail-qt1-f200.google.com with SMTP id g10-20020ac8768a0000b029023c90fba3dcso862072qtr.7 for ; Wed, 28 Jul 2021 04:44:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=n9cWpK1uIyz+JUOxEy9Pf+8xtIGLBX39ahEVhaWH4Tk=; b=t7vzqJESnn8vjypbV7laxJxnlrDMfljSPRBC4aYufo8fy0qpvpuppWQMGbLv8a32Z0 Zk/ZYk00Yox4HjVZfQplDekeQYGTA+bB+vVi9D0pWZ6qOVfBoISRbhOGx5jwqE9TPob3 hvd0cTOfgCsXP8FEoUu699xy0IlPyvPWZcmk0Aosmx5j6/hHU1z9lIWQW3ZyzOHL9DTX FlsELVHCHx4/d9RbDiK65HGs6N86md1IhiEHTRgLUWUFljamHnRZbdMUPqDlBThLcXYj GkH5yddplV5fv9iBjUKSlS7MUuH2WAj53ZbNmV7JWqloFfbQZu5f3fX3BWSAAjQYVR6X 8kBw== X-Gm-Message-State: AOAM530Zn5wPHFcE5FmbGbF0iA8N+BAHs3TEr5KnhKYCTRjQ0cStmEfG DxNlIFXMA++p7DuEPS9TMMMOWqnARVvyCSQKY0xal4XR/xCet62hOd7qKdibL18F5H0K7TircZ3 po1tySgrLcYSFj6FP8A== X-Received: by 2002:a05:6214:5085:: with SMTP id kk5mr28126034qvb.25.1627472645551; Wed, 28 Jul 2021 04:44:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzouFbUKnkjQeUMMKY0Bm1rpp6FjR7N06WX8XCvU3eE0pwfKeObBNqUmyf91GI5mzS2ppXa7Q== X-Received: by 2002:a05:6214:5085:: with SMTP id kk5mr28126023qvb.25.1627472645375; Wed, 28 Jul 2021 04:44:05 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.ma.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id x7sm3143419qki.102.2021.07.28.04.44.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jul 2021 04:44:05 -0700 (PDT) Message-ID: <511c08dcc611cc7e9ca05b101e7e11bc8c28e1e4.camel@redhat.com> Subject: Re: [PATCH] analyzer: Recognize __builtin_free as a matching deallocator From: David Malcolm To: Siddhesh Poyarekar , gcc-patches@gcc.gnu.org Date: Wed, 28 Jul 2021 07:44:04 -0400 In-Reply-To: <20210728050444.3843432-1-siddhesh@gotplt.org> References: <20210728050444.3843432-1-siddhesh@gotplt.org> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2021 11:44:09 -0000 On Wed, 2021-07-28 at 10:34 +0530, Siddhesh Poyarekar wrote: > Recognize __builtin_free as being equivalent to free when passed into > __attribute__((malloc ())), similar to how it is treated when it is > encountered as a call.  This fixes spurious warnings in glibc where > xmalloc family of allocators as well as reallocarray, memalign, > etc. are declared to have __builtin_free as the free function. > >         gcc/analyzer/ChangeLog: >         * sm-malloc.cc >         (malloc_state_machine::get_or_create_deallocator): Recognize >         __builtin_free. > >         gcc/testsuite/ChangeLog: >         * gcc.dg/analyzer/attr-malloc-1.c (compatible_alloc, >         compatible_alloc2): New extern allocator declarations. >         (test_9, test_10): New tests. Looks good to me, thanks Dave