From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 8B1383858D20 for ; Wed, 29 May 2024 19:11:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8B1383858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8B1383858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1717009869; cv=pass; b=h5H16EkJpr5RjzcWxQP0Up0gyDgpGqjgqqqrkI6uwevpqJirap8cblDd3qvb473YZGsbC6HbGM9JJiuGMwc4CSJip9LW1FIX+gziK2TD1FW+HEhxVMTHPEojanifjrozoCAEC2/VPq+Bz11bw7lbHsBkhU10EEw8Tjf6jYm4Fec= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1717009869; c=relaxed/simple; bh=bSSbGPYwlcto9uz+kTjXm3YGL4Ykp1xmXQCIH4hvbx4=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=n2gYvgFaJYgO8/THDStwe5hqmEZz9rtVpTkp1Lsryzo7lHLRhpoc49xLL6+C+ZD1HPbff1prLJoJ9j08FPneyF2GlHw6jSihmzjAE229F0uO8OjtOn+rRpfOTpYSHqKn1H9YxhtPdnF8e9iooi8WLFwAEYmUSEYd1e2Oa6CJoR4= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 44TGY61p010307; Wed, 29 May 2024 19:11:06 GMT DKIM-Signature: =?UTF-8?Q?v=3D1;_a=3Drsa-sha256;_c=3Drelaxed/relaxed;_d=3Doracle.com;_h?= =?UTF-8?Q?=3Dcc:content-id:content-transfer-encoding:content-type:date:fr?= =?UTF-8?Q?om:in-reply-to:message-id:mime-version:references:subject:to;_s?= =?UTF-8?Q?=3Dcorp-2023-11-20;_bh=3D/DAVFo51ZH7IHFPvGGcbISiLL6xJhgiuRDYg9M?= =?UTF-8?Q?+onZw=3D;_b=3DBBqm++7dBT0pePwkXOjGELdR90W6o8qfkgK5kBKPXZXd9c4/4?= =?UTF-8?Q?pQFE6elbfwZZ/KQLWiW_kpjkCr9eEVY8qSIgHiz58/15zpDmUQAqM6atU+2sq/2?= =?UTF-8?Q?cNj+EKJWxqt21JSfrII0z9Ce+_ut101qFSw2DSyhxKNwPR1a+87QWr5ApRhxhXh?= =?UTF-8?Q?JmUzYpAAOT6qhGrcipRDPuD9yzsb9ip_9PGoL+OyVpOt7dFAjkKfzEKcmSWLmZR?= =?UTF-8?Q?bCa1aoD0jJEs0sdlYrD81XwOoy21u12wb1r3+_Kg2g+MVs+UtFhuEeAQ3v4ljtJ?= =?UTF-8?Q?X7skL5WUMcfveR1YuwiX4czEXyqTn/95Giv47Mr0gyM_ow=3D=3D_?= Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3yb8fcfega-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 May 2024 19:11:06 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 44TIXt2I010817; Wed, 29 May 2024 19:11:05 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2168.outbound.protection.outlook.com [104.47.55.168]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3yc50ynq6s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 May 2024 19:11:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HoNdjFrzhZtxhCC2U4DOVUlF+tOHbHzqTcu53X5/TAbP4WSWFJOTt2pgndl5mFYP9xGWkfmhTdLE03gHqKAFnGQezpoxkK97HzGGKGoR1ymkL92+MkoMHbwBsXt1/lrQEb15jgRTXDd+xzBm6MJEaa0+YMjCUpxUOiKK92o+cuvdWvTHSAj0fop30nbPWYDPJK+Uxh8pNk+YJ7Td3sHZZTKkZ5DhWm4AJZg2Nx2AQlK7lnhf5pT/LdZ3+mvwRmldNx4xMhCHPvKjggFy3rJebWn0oguBSrjopmgH+2Pkroqcl6mHbFDAjDVQFJ/N31mKCP2C0eRrKHan0IAmoVtIZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/DAVFo51ZH7IHFPvGGcbISiLL6xJhgiuRDYg9M+onZw=; b=cuXtGy1cF4QRrWQ1V4mc8fVyNQapkFbwQwlxJKkNcPWmNRP7XwVJ63d5U8GPf3iHAX0+Kh4xy1KgJTBQ1XqxWHzRQi3JFREtQkmGlH78wYYhdXuBlcp0Mb2PFN/rfXoDphMkNcx+6JBZhuHYiSEx5NsB7QIuAvgTslnuXSwZOkoddnKEKbNmmHJf9o8pcjag/E52zpPzAThGejsPzNgmZyGLRPt+474kfQELKz9IEzrP3sFLgnAAoc8sxFlqMIGkhsqAA82JdsZ8kj8TRo81t+zzm5VzmhKNefJTdYX+yFQOdx5RwIR/hxFHfvr1MveeD2vLSbKKDSVYGG8XvSgioA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/DAVFo51ZH7IHFPvGGcbISiLL6xJhgiuRDYg9M+onZw=; b=IdUa+1Ttv4YtPTOeFme0du/VTcXwDoGNemIQCqwnO13I958QjdpdJ0A0VAjbRgDUY3Hzoqmb5Nqb9H2ZZHmT/YYyz7pclNZkosSO9SFf7FKqSPWusttjtYdloFfpiJJsmkjR/4ke3ZYmvEZAQGtkNEaDMdCoy3LEluiJ0EYFhHE= Received: from CY8PR10MB6538.namprd10.prod.outlook.com (2603:10b6:930:5a::17) by DS7PR10MB4926.namprd10.prod.outlook.com (2603:10b6:5:3ac::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.29; Wed, 29 May 2024 19:11:04 +0000 Received: from CY8PR10MB6538.namprd10.prod.outlook.com ([fe80::8a:61cd:764a:e47]) by CY8PR10MB6538.namprd10.prod.outlook.com ([fe80::8a:61cd:764a:e47%5]) with mapi id 15.20.7611.030; Wed, 29 May 2024 19:11:03 +0000 From: Qing Zhao To: Richard Biener , Joseph Myers CC: Siddhesh Poyarekar , "uecker@tugraz.at" , Kees Cook , "isanbard@gmail.com" , GCC Patches Subject: Re: [PATCH v9 2/5] Convert references with "counted_by" attributes to/from .ACCESS_WITH_SIZE. Thread-Topic: [PATCH v9 2/5] Convert references with "counted_by" attributes to/from .ACCESS_WITH_SIZE. Thread-Index: AQHajOD3iPKn6wcOPk2CGvd26vH0XrGsikYAgADifQCAAXFUgA== Date: Wed, 29 May 2024 19:11:03 +0000 Message-ID: <51215440-F891-4EC1-B1CD-8844BFBCEBD5@oracle.com> References: <20240412135430.4122328-1-qing.zhao@oracle.com> <20240412135430.4122328-3-qing.zhao@oracle.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3774.500.171.1.1) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY8PR10MB6538:EE_|DS7PR10MB4926:EE_ x-ms-office365-filtering-correlation-id: 988b689f-7bb3-4432-ae0f-08dc801315cc x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230031|1800799015|376005|366007|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?gS1xv3RYma6cKn9v5vag6gZduSMr80bNULK6hpJ5xDoPNIfO7s7WKp6hlaJZ?= =?us-ascii?Q?IXuxZAGzZ6l8yNGv9MFM0T9ph9nxErBSr9HlMuWQUACHK5M7IWHQsuJ4NVgK?= =?us-ascii?Q?QJquUrgNEi+6itq9hL/Cb1o96HKFFfQxC11BBU/MCdttWvfGFdxJubXZPhl3?= =?us-ascii?Q?NxiZk0DvdOpjdO4dbNGiIsegWG4xz8blaL9OkNLiz77fBkFCz6sGdalJzJi3?= =?us-ascii?Q?MY3/2beWksJSNdH/6i+d30s/gVjUw+Vdn+LDIlmnaWQZwp/1fNC8zcZzhwGS?= =?us-ascii?Q?S8PES7vlFKh7ZgGaGB0Vw5CetFxE5ZCLH9VuIMcDF0QUBCDhvaszRepgWgD3?= =?us-ascii?Q?3hLClNXBkMxVL6zXwSYD+eQ6BExeR/KDRnXqp3vYzMaXrY6iMOa4CNzXxw0C?= =?us-ascii?Q?7gCBFSGCzBIdoBcgx4PRV0VwebhJ4emnfTB9xtvkU+5+Hh2SlFJHKExsK28i?= =?us-ascii?Q?Aj5JNbCoJFn+k01xMGdy506T+UhlicFzKCao8NtyiPOMymvr3latD3dNpgu1?= =?us-ascii?Q?UpDnVoItr6HrH309IBH1N14Zl4tXjQ1/rL3P8HvZG5si8RrRYzzCtr2fQ4/A?= =?us-ascii?Q?VtSzIb0pfTSwPBn1Pq6TQrQWOHcle4mTfutkZtKjBgrVQeeI7SWwRcvCIhkr?= =?us-ascii?Q?T9ZGhisa2xNNNk6ow7g4hpJRD9ME3OBXqcN271lFRJuk0MemKW5TQWPzs8Ws?= =?us-ascii?Q?hX2yXP9+th4g3QCcpM2n7Dbe8iMZZTgpJvf4HfycX0zcJvQhE319GczqWifr?= =?us-ascii?Q?1tKmqAqI3xSHh8F8wVNR3uERtmaUrmpYwSorLLearAoI20b4oXRGEWjI4OKU?= =?us-ascii?Q?MgFkGa/S/LnqeZNJEVNwUR8cSstZnjOj7pow+Egv0AnS3WfMuRKrHWyyAOvS?= =?us-ascii?Q?o3oHnGD/rKuX+yIhtWGUPIFixr0EutzxsX33rekzuxbGrc6kv6NAf3cThB8k?= =?us-ascii?Q?xRXh6S455+QQmk4qZ5nAHbKvBA/ZtmmIgWlTqKxCgQXM4mzTwj4bPLTUrH17?= =?us-ascii?Q?VPyiEhDdVYqGSAkriUwg+f8PY/26Ff50MQdumvcEOSB0H/Fp8KzHmXNs/kTj?= =?us-ascii?Q?wRc4zxtHW0RcnFlNOFM8k6KbQW0LCNETt4zvfy0c5jgOkYMaDoEE4It0vUKa?= =?us-ascii?Q?47H4hiBEobpXDcmc30x4chLddGLsPO/aQLdp0HQdpMHq09CHvglw1/sbuTfZ?= =?us-ascii?Q?BiAv+C9o5JMdxd6xOomz+Un+UDWmTbNQbA1n7o3B95CA4PwSiXDgbHpg7+5E?= =?us-ascii?Q?iGQ/gfoozlqYsbusMuxZvDrudenz+NJDIWBhPNQPFMse+5tDencenunKHer/?= =?us-ascii?Q?mPcEtMm8Cz5c/oyA+e3sVmMVWN1RKF8M8qYuF91Bs1g71g=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR10MB6538.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005)(366007)(38070700009);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7WKkF6eZ5rN2Xe1aDG+uBbboxty3sI9AjRIqYVu/S5B7j17JTpmowoApKRBV?= =?us-ascii?Q?MXFd7wL+JKL/8iFzF3xfUc6QkReHJ8yRd9DDIjMIlFiewTnQxv1FteRJDURf?= =?us-ascii?Q?8hyPuPP8/Bbov07MPN9DUiJLzvT+dIJuy1tCcuwynGbozawKI5rn5gXcuZK5?= =?us-ascii?Q?JhkwdXHFH/5vj3OtAdKRBqi6NJxpA+0r66f9Ot/FDGy2QuRn/exaFnMDYw9l?= =?us-ascii?Q?V5kLdeHP2mWybC0Sx+UEUCSiSZPnLppo9vmzjDmQEJ4hHC++NYe0EX0QaOMD?= =?us-ascii?Q?P34VzQJwEoHJamIbx8lju3+gXpS75GgumVX1SUd38VqO3O4e8HfEAtAZKEHv?= =?us-ascii?Q?BFW4T2w0PrLpKdILq2j+PcQAg67jARR425mSjDp+H9PzEEm6v/GJiuOxPZ8J?= =?us-ascii?Q?h55Ln3+kWevjGPsOL/JNRCH8LErppK1B5EicH4n9iVAOlTOL34lCgyVyzWg/?= =?us-ascii?Q?fHilwHqE1oet1c0zvDbyPzSjgjsdx0+5kyJzMzE/TRFBiFy+tL3aIyNLw4sI?= =?us-ascii?Q?cbffMegFaA0qxcS3Rp3uZgLf6SV1/3UFtt1tuxdkQ05vYxS3Oz+MksnKkwhY?= =?us-ascii?Q?Tx5ISRCp2Ddz/JyRUMC9wJhPHraobD1Qt3JyKZT77RJEAA3dhsUAe2qyfvIe?= =?us-ascii?Q?WG1Ve7FacIqgkICmYAh4zLjzsbcJsYdPJ2hfZJoejuGmRHHTGty3SC5CU0Ca?= =?us-ascii?Q?u5xTXQIYjc6RBNoz5KJkOpzliY2CER7uK16ib82Sg4KQg+x9F9s3UoLE6WCI?= =?us-ascii?Q?7UkwyXCnuDeY677klUNY1WZgUWKVJz6psZH32106SqIeeaXNPP9dAK2SpaLO?= =?us-ascii?Q?gNGhEhLBAG9kstX1T+w3GFI6qUjJT/UIvsmoE9avb7nLkZgbjVhng4kHx4V2?= =?us-ascii?Q?K3TAh39L1qXRthzpLxXH8HPq+wLd/AVmX+admUCsEnYd5K55AHUr3aE2Rqwg?= =?us-ascii?Q?0YyZhg8xASTggWTaqGIvLNymgh+II0E/KQ8G+XvG8JBqxgmvehm9vsIeb6kX?= =?us-ascii?Q?cN6MW4sxho+6ugXsiFLr/hv7e3/dS9QYaCwQaqIiLHkNMeHX+SBIifcSpZgs?= =?us-ascii?Q?45zFu4Otm52nftvXO1Bh7p5vHHx2mSeMVW5D1Y/ErW/FXzsIUKgDXTSLsabf?= =?us-ascii?Q?jHUjh5KI5KQsAAX91A/EYx8y7UtKgTgLOULNZTX794YIw5FdJBZCGvHbFNzN?= =?us-ascii?Q?UH93u9OAVJ0mgRmnxnmP3wdZ+kGcUHxj1EEhcVG0ypD4w+4nuDabXD0zRO0G?= =?us-ascii?Q?sRGlkq0MUFFPhlBECziUuWBe22BEyBfbshZAuhKZpuGKvxqJd6l6TCY+/NKE?= =?us-ascii?Q?SuxGUZtm8l4APd5eV5xkRiFCKgNr1ltnnrcMoCmhxww+7SANv7mBMboCpvKn?= =?us-ascii?Q?13wkzBGeB/Y5jCmBnRAw3TO8FFwXjMW8uAHWQRhF3VJQWcpOGK6VIuZjI6bJ?= =?us-ascii?Q?2S3VzMr1AdRatgUbW9iHz4bEWi6KkjqAOyMI5YthPo+Np30R3BqyS8BLFjSW?= =?us-ascii?Q?f3r6WQK1b2bRN8uGoYUp3dmuJEUBBOVAsDBjE2LXy6khYHFo00q4rRlJZUkB?= =?us-ascii?Q?n/cQ6E2G2A47cX3nAp77yA6RL/yy8u2zMeydrt0b?= Content-Type: text/plain; charset="us-ascii" Content-ID: <03B6E71C05BBAD4AB69728F65D4B8D7F@namprd10.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: RMVeZe94pNoQNNYPwurH7Gy7DLFFr/fTQBalmbmRgG+cctHuufkp2SHClS+/ll2oRaJEl+OwInbZPwC/GINeT+3HFjoAMaoVz//ug2S2eqJhP1dJNQYdzIuT8HVdhmvgj2ounRiQFaD6r27KL8yCGyCEsXmanjs+2d4jhHAV2Kny9ovBZ6QuXQLAhyLodS2q/yHDYBBpqG6I7oYaJv2u2M/uoqW/i9nUlXfttX8c1QSlEHF1sKUBGdtAfaIj2flNfwilM61dlaAH19GgJ1FZp+OtTkHSR5MC+tPrmxhtL0xL2+HbVHCkryRYwU1sPqrTIZCqT9NR2Hzh9pV5JGIeeZjK/+Zpoo6gLtABOeT5FWDzm25Lp7awalgFc05TQIbRUPzKKXrTcJnVcycD8Kz10dEiopVzPushpOYev1ohKJwRfZYVIjLAHKdrPfUjzhrPsoJf8arc0yEuCfneaEEQLcBzmMAqDlfaYhhRWCk7Pb0eyHIrDpYLKJnkYwlbHYFVjgus25D/XM7BajvYJKRtQ0R+CP54hckRvshT+vifCvZL3mRc1sLe9wHOGq3ROkJn/PGjS/F8JUMDmGYWICN2DiUxtJ+b9iB4BlnBz03Nx+k= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY8PR10MB6538.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 988b689f-7bb3-4432-ae0f-08dc801315cc X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2024 19:11:03.7992 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3Jp1s/4noohyfLIsX2NYFYe7HV8HKgu8c1PQlo2/2YTzlmZUD1ALI8tMQyaym5JWCVkWa6HQyBSpxttu3YYi9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB4926 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16 definitions=2024-05-29_15,2024-05-28_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 spamscore=0 adultscore=0 mlxscore=0 phishscore=0 suspectscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000 definitions=main-2405290133 X-Proofpoint-GUID: NWW-lLQxUl8iXyJ-PKvaoYK8B6_GlnM- X-Proofpoint-ORIG-GUID: NWW-lLQxUl8iXyJ-PKvaoYK8B6_GlnM- X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,KAM_DMARC_QUARANTINE,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Richard and Joseph: > On May 28, 2024, at 17:09, Qing Zhao wrote: >=20 >>>=20 >>> diff --git a/gcc/varasm.cc b/gcc/varasm.cc >>> index fa17eff551e8..d75b23668925 100644 >>> --- a/gcc/varasm.cc >>> +++ b/gcc/varasm.cc >>> @@ -5082,6 +5082,11 @@ initializer_constant_valid_p_1 (tree value, tree= endtype, tree *cache) >>> } >>> return ret; >>>=20 >>> + case CALL_EXPR: >>> + /* For a call to .ACCESS_WITH_SIZE, check the first argument. *= / >>> + if (tree ref =3D get_ref_from_access_with_size (value)) >>> + return initializer_constant_valid_p_1 (ref, endtype, cache); >>=20 >> I think we should fold/strip .ACCESS_WITH_SIZE from initializers >> instead. That would be >> the frontends job I guess, most probably not even generate those in >> the first place? >=20 > Sounds reasonable, I will see how to do this in C FE.=20 > Joseph, do you have any suggestion where in C FE I should do this folding= ?=20 >=20 > thanks. >=20 > Qing In order to address this above comment from Richard, I studied a little bit= more on the C FE code, and then come up with the following patch: diff --git a/gcc/c/c-typeck.cc b/gcc/c/c-typeck.cc index ac306749e8d7..efd111305b5a 100644 --- a/gcc/c/c-typeck.cc +++ b/gcc/c/c-typeck.cc @@ -8650,6 +8650,20 @@ digest_init (location_t init_loc, tree type, tree in= it, tree origtype, STRIP_TYPE_NOPS (inside_init); + /* If require_constant is TRUE, when the initializer is a call to + .ACCESS_WITH_SIZE, use the first argument as the initializer. + For example: + y =3D (char *) .ACCESS_WITH_SIZE ((char *) &static_annotated.c,...) + will be converted to + y =3D &static_annotated.c. */ + + if (require_constant + && TREE_CODE (inside_init) =3D=3D NOP_EXPR + && TREE_CODE (TREE_OPERAND (inside_init, 0)) =3D=3D CALL_EXPR + && is_access_with_size_p (TREE_OPERAND (inside_init, 0))) + inside_init + =3D get_ref_from_access_with_size (TREE_OPERAND (inside_init, 0)); + if (!c_in_omp_for) { if (TREE_CODE (inside_init) =3D=3D EXCESS_PRECISION_EXPR) diff --git a/gcc/varasm.cc b/gcc/varasm.cc index 2e8fa5e30a80..e1a8458f8749 100644 --- a/gcc/varasm.cc +++ b/gcc/varasm.cc @@ -5078,10 +5078,6 @@ initializer_constant_valid_p_1 (tree value, tree end= type, tree *cache) } return ret; - case CALL_EXPR: - /* For a call to .ACCESS_WITH_SIZE, check the first argument. */ - if (tree ref =3D get_ref_from_access_with_size (value)) - return initializer_constant_valid_p_1 (ref, endtype, cache); /* FALLTHROUGH. */ default: break; @@ -5277,11 +5273,6 @@ output_constant (tree exp, unsigned HOST_WIDE_INT si= ze, unsigned int align, exp =3D TREE_OPERAND (exp, 0); } - /* For a call to .ACCESS_WITH_SIZE, check the first argument. */ - if (TREE_CODE (exp) =3D=3D CALL_EXPR) - if (tree ref =3D get_ref_from_access_with_size (exp)) - exp =3D ref; - code =3D TREE_CODE (TREE_TYPE (exp)); This resolved the issue well.=20 Let me know if you have any comment or suggestion.=20 I have fixed all the issues Richard raised in my private workspace, testing= is ongoing. Will post the modified patch set soon. Thanks a lot! Qing=