From: Marcus Shawcroft <marcus.shawcroft@arm.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Richard Earnshaw <Richard.Earnshaw@arm.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix install-plugin on arm and aarch64
Date: Wed, 06 Mar 2013 09:32:00 -0000 [thread overview]
Message-ID: <51370D22.8060004@arm.com> (raw)
In-Reply-To: <20130306090736.GQ12913@tucnak.redhat.com>
On 06/03/13 09:07, Jakub Jelinek wrote:
> Hi!
>
> https://bugzilla.redhat.com/show_bug.cgi?id=910926
> reports that plugins aren't usable on arm, because arm-cores.def isn't
> installed into the plugins directory. arm-cores.def can't be included in
> tm_file list, because we don't want to include it directly, nor in
> HeaderInclude in arm.opt (that breaks the build). rs6000 has similar issue
> with its rs6000-builtin.def, and solves this by adding content to TM_H
> in Makefile fragment.
>
> Thus, the following patch does the same for arm (and apparently aarch64 has
> the same issue). Ok for trunk?
>
> 2013-03-06 Jakub Jelinek <jakub@redhat.com>
>
> * config/aarch64/t-aarch64 (TM_H, OPTIONS_H_EXTRA): Add
> aarch64-cores.def.
> * config/arm/t-arm (TM_H, OPTIONS_H_EXTRA): Add arm-cores.def.
>
> --- gcc/config/aarch64/t-aarch64.jj 2013-02-24 19:44:07.000000000 +0100
> +++ gcc/config/aarch64/t-aarch64 2013-03-06 09:42:31.568042231 +0100
> @@ -18,6 +18,9 @@
> # along with GCC; see the file COPYING3. If not see
> # <http://www.gnu.org/licenses/>.
>
> +TM_H += $(srcdir)/config/aarch64/aarch64-cores.def
> +OPTIONS_H_EXTRA += $(srcdir)/config/aarch64/aarch64-cores.def
> +
> $(srcdir)/config/aarch64/aarch64-tune.md: $(srcdir)/config/aarch64/gentune.sh \
> $(srcdir)/config/aarch64/aarch64-cores.def
> $(SHELL) $(srcdir)/config/aarch64/gentune.sh \
> --- gcc/config/arm/t-arm.jj 2013-01-11 09:03:13.000000000 +0100
> +++ gcc/config/arm/t-arm 2013-03-06 09:41:09.607528642 +0100
> @@ -18,6 +18,9 @@
> # along with GCC; see the file COPYING3. If not see
> # <http://www.gnu.org/licenses/>.
>
> +TM_H += $(srcdir)/config/arm/arm-cores.def
> +OPTIONS_H_EXTRA += $(srcdir)/config/arm/arm-cores.def
> +
> # All md files - except for arm.md.
> # This list should be kept in alphabetical order and updated whenever an md
> # file is added or removed.
>
> Jakub
> [A
>
AArch64 patch is OK.
ARM looks fine but I can't OK that one.
Cheers
/Marcus
next prev parent reply other threads:[~2013-03-06 9:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 9:07 Jakub Jelinek
2013-03-06 9:32 ` Marcus Shawcroft [this message]
2013-03-06 10:57 ` Matthias Klose
2013-03-06 11:06 ` Jakub Jelinek
2013-03-06 12:44 ` [PATCH] Fix install-plugin with vxworks-dummy.h (PR plugins/45078) Jakub Jelinek
2013-03-08 17:24 ` Jakub Jelinek
2013-03-12 15:47 ` Matthias Klose
2013-03-06 23:05 ` [PATCH] Fix install-plugin on arm and aarch64 Ramana Radhakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51370D22.8060004@arm.com \
--to=marcus.shawcroft@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).