public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: C++ PATCH for c++/56567 (ICE with lambda returning init-list)
Date: Fri, 08 Mar 2013 15:55:00 -0000	[thread overview]
Message-ID: <513A09D3.5020900@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

My initial proposal for allowing general return type deduction allowed 
deduction of std::initializer_list, which is not permitted by C++11. 
But this doesn't make sense, because the underlying array will 
immediately leak, so we should just give an error even in C++1y.

Tested x86_64-pc-linux-gnu, applying to trunk.

[-- Attachment #2: 56567.patch --]
[-- Type: text/x-patch, Size: 1238 bytes --]

commit 10c6627ac3371930fe44868ad94cb2ebc9d4e908
Author: Jason Merrill <jason@redhat.com>
Date:   Fri Mar 8 10:25:55 2013 -0500

    	PR c++/56567
    	* semantics.c (apply_deduced_return_type): Don't allow returning
    	std::initializer_list.

diff --git a/gcc/cp/semantics.c b/gcc/cp/semantics.c
index f1eb9ba..5c93a25 100644
--- a/gcc/cp/semantics.c
+++ b/gcc/cp/semantics.c
@@ -9061,6 +9061,12 @@ apply_deduced_return_type (tree fco, tree return_type)
   if (return_type == error_mark_node)
     return;
 
+  if (is_std_init_list (return_type))
+    {
+      error ("returning %qT", return_type);
+      return_type = void_type_node;
+    }
+
   if (LAMBDA_FUNCTION_P (fco))
     {
       tree lambda = CLASSTYPE_LAMBDA_EXPR (current_class_type);
diff --git a/gcc/testsuite/g++.dg/cpp0x/lambda/lambda-initlist3.C b/gcc/testsuite/g++.dg/cpp0x/lambda/lambda-initlist3.C
new file mode 100644
index 0000000..029287b
--- /dev/null
+++ b/gcc/testsuite/g++.dg/cpp0x/lambda/lambda-initlist3.C
@@ -0,0 +1,11 @@
+// PR c++/56567
+// { dg-require-effective-target c++11 }
+
+#include <initializer_list>
+
+int main()
+{
+  []{ return { 1, 2 }; }();	// { dg-error "initializer_list" }
+}
+
+// { dg-prune-output "return-statement with a value" }

             reply	other threads:[~2013-03-08 15:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-08 15:55 Jason Merrill [this message]
2013-03-11 16:20 ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513A09D3.5020900@redhat.com \
    --to=jason@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).