From: Michael Eager <eager@eagerm.com>
To: David Holsgrove <david.holsgrove@xilinx.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Edgar Iglesias <edgari@xilinx.com>,
John Williams <jwilliams@xilinx.com>,
Vinod Kathail <vinodk@xilinx.com>,
Vidhumouli Hunsigida <vidhum@xilinx.com>,
Nagaraju Mekala <nmekala@xilinx.com>, Tom Shui <tshui@xilinx.com>
Subject: Re: [Patch, microblaze]: Add support for TLS in MicroBlaze
Date: Wed, 13 Mar 2013 15:34:00 -0000 [thread overview]
Message-ID: <51409C62.50502@eagerm.com> (raw)
In-Reply-To: <d9b33193-077a-4c31-b35f-813323bc50a0@DB8EHSMHS031.ehs.local>
On 03/12/2013 01:47 PM, David Holsgrove wrote:
> Add support for thread local storage (general dynamic and local dynamic models) in MicroBlaze.
>
>
> gcc/Changelog
>
> 2013-03-13 Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> David Holsgrove <david.holsgrove@xilinx.com>
>
> * config/microblaze/microblaze-protos.h: (microblaze_cannot_force_const_mem,
> microblaze_tls_referenced_p, symbol_mentioned_p,
> label_mentioned_p): Add prototypes.
> * config/microblaze/microblaze.c (microblaze_address_type): Add ADDRESS_TLS
> and tls_reloc address types.
> (microblaze_address_info): Add tls_reloc.
> (TARGET_HAVE_TLS): Define.
> (get_tls_get_addr, microblaze_tls_symbol_p, microblaze_tls_operand_p_1,
> microblaze_tls_referenced_p, microblaze_cannot_force_const_mem,
> symbol_mentioned_p, label_mentioned_p, tls_mentioned_p, load_tls_operand,
> microblaze_call_tls_get_addr, microblaze_legitimize_tls_address): New functions.
> (microblaze_classify_unspec): Handle UNSPEC_TLS.
> (get_base_reg): Use microblaze_tls_symbol_p.
> (microblaze_classify_address): Handle TLS.
> (microblaze_legitimate_pic_operand): Use symbol_mentioned_p, label_mentioned_p
> and microblaze_tls_referenced_p.
> (microblaze_legitimize_address): Handle TLS.
> (microblaze_address_insns): Handle ADDRESS_TLS.
> (pic_address_needs_scratch): Handle TLS.
> (print_operand_address): Handle TLS.
> (microblaze_expand_prologue): Check TLS_NEEDS_GOT.
> (microblaze_expand_move): Handle TLS.
> (microblaze_legitimate_constant_p): Check microblaze_cannot_force_const_mem
> and microblaze_tls_symbol_p.
> (TARGET_CANNOT_FORCE_CONST_MEM): Define.
> * config/microblaze/microblaze.h (TLS_NEEDS_GOT): Define
> (PIC_OFFSET_TABLE_REGNUM): Set.
> * config/microblaze/linux.h (TLS_NEEDS_GOT): Define.
> * config/microblaze/microblaze.md (UNSPEC_TLS): Define.
> (addsi3, movsi_internal2, movdf_internal): Update constraints
> * config/microblaze/predicates.md (arith_plus_operand): Define
> (move_operand): Redefine as move_src_operand, check microblaze_tls_referenced_p.
>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
Hi David --
The patch is OK except for a number of minor formatting problems to meet GNU standards.
- Comments are supposed to end with ". */".
- Extra spacing around parens or between "!" and "TARGET...".
- && or || at start of line continuing a condition rather that at end of previous line
- Some places where the indenting is incorrect
Should this patch be combined with the other patch adding TLS checking to configure?
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
next prev parent reply other threads:[~2013-03-13 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 20:47 David Holsgrove
2013-03-13 15:34 ` Michael Eager [this message]
2013-03-14 8:08 ` David Holsgrove
2013-03-14 15:46 ` Michael Eager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51409C62.50502@eagerm.com \
--to=eager@eagerm.com \
--cc=david.holsgrove@xilinx.com \
--cc=edgari@xilinx.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwilliams@xilinx.com \
--cc=nmekala@xilinx.com \
--cc=tshui@xilinx.com \
--cc=vidhum@xilinx.com \
--cc=vinodk@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).