From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2180 invoked by alias); 14 Mar 2013 15:46:53 -0000 Received: (qmail 2171 invoked by uid 22791); 14 Mar 2013 15:46:52 -0000 X-SWARE-Spam-Status: No, hits=-3.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from caibbdcaaaaf.dreamhost.com (HELO homiemail-a83.g.dreamhost.com) (208.113.200.5) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Mar 2013 15:46:07 +0000 Received: from homiemail-a83.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a83.g.dreamhost.com (Postfix) with ESMTP id 1F0EC5E078; Thu, 14 Mar 2013 08:46:07 -0700 (PDT) Received: from redwood.eagercon.com (c-50-148-128-197.hsd1.ca.comcast.net [50.148.128.197]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a83.g.dreamhost.com (Postfix) with ESMTPSA id 9CDCC5E082; Thu, 14 Mar 2013 08:46:06 -0700 (PDT) Message-ID: <5141F0BD.402@eagerm.com> Date: Thu, 14 Mar 2013 15:46:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 MIME-Version: 1.0 To: David Holsgrove CC: "gcc-patches@gcc.gnu.org" , Edgar Iglesias , John Williams , Vinod Kathail , Vidhumouli Hunsigida , Nagaraju Mekala , Tom Shui Subject: Re: [Patch, microblaze]: Add support for TLS in MicroBlaze References: <51409C62.50502@eagerm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-03/txt/msg00511.txt.bz2 On 03/14/2013 01:07 AM, David Holsgrove wrote: > Hi Michael, > >> -----Original Message----- >> From: Michael Eager [mailto:eager@eagerm.com] >> Sent: Thursday, 14 March 2013 1:34 am >> To: David Holsgrove >> Cc: gcc-patches@gcc.gnu.org; Edgar Iglesias; John Williams; Vinod Kathai= l; >> Vidhumouli Hunsigida; Nagaraju Mekala; Tom Shui >> Subject: Re: [Patch, microblaze]: Add support for TLS in MicroBlaze >> >> On 03/12/2013 01:47 PM, David Holsgrove wrote: >>> Add support for thread local storage (general dynamic and local dynamic >> models) in MicroBlaze. >>> >>> >>> gcc/Changelog >>> >>> 2013-03-13 Edgar E. Iglesias >>> David Holsgrove >>> > [--snip--] >>> >>> Signed-off-by: Edgar E. Iglesias >>> Signed-off-by: David Holsgrove >> >> Hi David -- >> >> The patch is OK except for a number of minor formatting problems to meet= GNU >> standards. >> - Comments are supposed to end with ". */". >> - Extra spacing around parens or between "!" and "TARGET...". >> - && or || at start of line continuing a condition rather that at end of= previous line >> - Some places where the indenting is incorrect >> > > Thanks for the review, we inherited some of the style deviations when bas= ing off > of other archs TLS functions I'm afraid. I've fixed the formatting in v2 = of the patch > attached. > >> Should this patch be combined with the other patch adding TLS checking to >> configure? >> > > I've combined both patches into the attached - looking back at the ARM TL= S patch > it was submitted this way, so we'll follow precedence there if that=E2=80= =99s okay with > you. > > Updated Changelog would be; > > 2013-03-14 Edgar E. Iglesias > David Holsgrove > > * configure.ac: Add MicroBlaze TLS support detection. > * configure: Regenerate. > * config/microblaze/microblaze-protos.h: (microblaze_cannot_force_const= _mem, > microblaze_tls_referenced_p, symbol_mentioned_p, > label_mentioned_p): Add prototypes. > * config/microblaze/microblaze.c (microblaze_address_type): Add ADDRESS= _TLS > and tls_reloc address types. > (microblaze_address_info): Add tls_reloc. > (TARGET_HAVE_TLS): Define. > (get_tls_get_addr, microblaze_tls_symbol_p, microblaze_tls_operand_p_= 1, > microblaze_tls_referenced_p, microblaze_cannot_force_const_mem, > symbol_mentioned_p, label_mentioned_p, tls_mentioned_p, load_tls_ope= rand, > microblaze_call_tls_get_addr, microblaze_legitimize_tls_address): Ne= w functions. > (microblaze_classify_unspec): Handle UNSPEC_TLS. > (get_base_reg): Use microblaze_tls_symbol_p. > (microblaze_classify_address): Handle TLS. > (microblaze_legitimate_pic_operand): Use symbol_mentioned_p, label_me= ntioned_p > and microblaze_tls_referenced_p. > (microblaze_legitimize_address): Handle TLS. > (microblaze_address_insns): Handle ADDRESS_TLS. > (pic_address_needs_scratch): Handle TLS. > (print_operand_address): Handle TLS. > (microblaze_expand_prologue): Check TLS_NEEDS_GOT. > (microblaze_expand_move): Handle TLS. > (microblaze_legitimate_constant_p): Check microblaze_cannot_force_con= st_mem > and microblaze_tls_symbol_p. > (TARGET_CANNOT_FORCE_CONST_MEM): Define. > * config/microblaze/microblaze.h (TLS_NEEDS_GOT): Define > (PIC_OFFSET_TABLE_REGNUM): Set. > * config/microblaze/linux.h (TLS_NEEDS_GOT): Define. > * config/microblaze/microblaze.md (UNSPEC_TLS): Define. > (addsi3, movsi_internal2, movdf_internal): Update constraints > * config/microblaze/predicates.md (arith_plus_operand): Define > (move_operand): Redefine as move_src_operand, check microblaze_tls_re= ferenced_p. > > Signed-off-by: Edgar E. Iglesias > Signed-off-by: David Holsgrove Thanks for cleaning up the patch. There were a few other places where I fi= xed indent and other formatting issues. Committed revision 196659. --=20 Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077