From: Tobias Burnus <burnus@net-b.de>
To: Tilo Schwarz <tilo@tilo-schwarz.de>
Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [Patch, libfortran, 2nd version] PR 48618 - Negative unit number in OPEN(...) is sometimes allowed
Date: Tue, 19 Mar 2013 11:19:00 -0000 [thread overview]
Message-ID: <51484578.3090805@net-b.de> (raw)
In-Reply-To: <op.wtk4c2ixa8ed4e@dellschleppa.fritz.box>
Am 07.03.2013 17:35, schrieb Tilo Schwarz:
> On Thu, 07 Mar 2013 12:46:10 +0100, Tobias Burnus <burnus@net-b.de>
> wrote:
>> Tilo Schwarz wrote:
>>> this patch fixes PR 48618.
>>> Built and regtested on Linux 3.2.0-4-686-pae.
>>
>> Thanks for the patch, which mostly looks okay.
>> A few remarks:
>
> Thank you for the feedback.
> I incorporated all remarks into the new attached patch.
The patch looks good and is okay for the 4.9 trunk. Thanks for your efforts!
If you commit yourself, you need to recall to split the ChangeLog into
the parts which go into libgfortran/ChangeLog and
gcc/testsuite/ChangeLog. For the commit log, use "svn log|less" to see
what others do for the commit log.
If you want me to commit this (and the other) patch instead, please tell me.
Tobias
next prev parent reply other threads:[~2013-03-19 11:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <op.wti2pupfa8ed4e@dellschleppa.fritz.box>
2013-03-07 10:48 ` Tilo Schwarz
2013-03-07 11:46 ` Tobias Burnus
2013-03-07 16:35 ` Tilo Schwarz
2013-03-19 11:19 ` Tobias Burnus [this message]
2013-03-19 21:22 ` Tilo Schwarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51484578.3090805@net-b.de \
--to=burnus@net-b.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tilo@tilo-schwarz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).