From: Tobias Burnus <burnus@net-b.de>
To: Tilo Schwarz <tilo@tilo-schwarz.de>
Cc: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [Patch, libfortran] PR51825 - Fortran runtime error: Cannot match namelist object name
Date: Wed, 20 Mar 2013 08:05:00 -0000 [thread overview]
Message-ID: <51496DC6.2090104@net-b.de> (raw)
In-Reply-To: <op.wtlfjuvda8ed4e@dellschleppa.fritz.box>
Hi Tilo,
I have now committed your two patches.
* PR 48618 - Negative unit number in OPEN(...) is sometimes allowed (as
Rev. 196805)
which was approved here:
http://thread.gmane.org/gmane.comp.gcc.fortran/40435/focus=40455 (It's
not in the gcc.gnu.org/ml/fortran as the server didn't record the mails
at that point)
* This patch (as Rev. 196806)
Congratulation to the committal of your first two patches - and thanks
again for your work.
Two remarks:
Tilo Schwarz wrote:
> 2013-03-07 Tilo Schwarz<tilo@tilo-schwarz.de>
>
> PR libfortran/51825
> * io/list_read.c (nml_read_obj): Don't end the component loop on a
> nested derived type, but continue with the next loop iteration.
> (nml_get_obj_data): Don't move the first_nl pointer further in the
> list if a qualifier was found.
> * gcc/testsuite/gfortran.dg/namelist_77.f90: New.
> * gcc/testsuite/gfortran.dg/namelist_78.f90: New.
The change log ends up in two files: libgfortran/ChangeLog and
gcc/testsuite/ChangeLog. File names are relative to those files. Hence,
I removed "gcc/testsuite/" before committal.
> +++ b/gcc/testsuite/gfortran.dg/namelist_77.f90
> @@ -0,0 +1,48 @@
> +! { dg-do run }
> +! PR 51825 - Fortran runtime error: Cannot match namelist object name
> +! Test case derived from PR.
...
> +++ b/gcc/testsuite/gfortran.dg/namelist_78.f90
> @@ -0,0 +1,32 @@
> +! { dg-do run }
> +! Test case regarding namelist problems with derived types
It is useful to quickly see from which bug/problem report the test case
came from. Thus, I added "PR libfortran/51825". (Using PR 51825 is also
fine; btw. there is no need to add a full link to Bugzilla as the PR
number is sufficient.)
Tobias
prev parent reply other threads:[~2013-03-20 8:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 20:37 Tilo Schwarz
2013-03-20 8:05 ` Tobias Burnus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51496DC6.2090104@net-b.de \
--to=burnus@net-b.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tilo@tilo-schwarz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).