From: Aldy Hernandez <aldyh@redhat.com>
To: "Iyer, Balaji V" <balaji.v.iyer@intel.com>
Cc: Jakub Jelinek <jakub@redhat.com>, Jeff Law <law@redhat.com>,
"Joseph S. Myers" <joseph@codesourcery.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] cilkplus array notation for C (clean, independent patchset, take 1)
Date: Thu, 21 Mar 2013 13:09:00 -0000 [thread overview]
Message-ID: <514B0657.3090802@redhat.com> (raw)
In-Reply-To: <BF230D13CA30DD48930C31D40993300016D7D9BB@FMSMSX102.amr.corp.intel.com>
On 03/21/13 08:06, Iyer, Balaji V wrote:
>>
>> Balaji, please check the corresponding .sum files before and after your patch to
>> make sure that the same number of tests are being tested. We have a nifty
>> script in contrib/compare_tests for this task.
>
> That's how I verify it. (I grep for the ^FAIL in trunk and the applied branch and make sure the output files are the same by going through it). Did I miss anything?
If you're using compare_tests, you should be fine. But just grepping
for FAIL won't do because there are tests that could have passed before,
but are no longer being tested, so they don't show up as a fail. I
believe compare_tests complains with "tests that used to pass but have
disappeared" (or something similar).
>
>>
>> And as Jakub has said, check (with and) without parallelization.
>>
>
> Yes, I am doing that also for the patch I am submitting.
Thank you.
next prev parent reply other threads:[~2013-03-21 13:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 15:32 Aldy Hernandez
2013-03-20 16:33 ` Aldy Hernandez
2013-03-20 22:28 ` Iyer, Balaji V
2013-03-21 12:55 ` Aldy Hernandez
2013-03-21 5:31 ` Jeff Law
2013-03-21 6:09 ` Jakub Jelinek
2013-03-21 13:01 ` Aldy Hernandez
2013-03-21 13:06 ` Iyer, Balaji V
2013-03-21 13:09 ` Aldy Hernandez [this message]
2013-03-21 13:15 ` Iyer, Balaji V
2013-03-21 16:54 ` Mike Stump
2013-03-21 23:34 ` Aldy Hernandez
2013-03-22 22:36 ` Mike Stump
2013-03-23 1:36 ` Iyer, Balaji V
2013-03-23 5:00 ` Mike Stump
2013-03-20 22:00 ` [cilkplus-merge] test for side effects Aldy Hernandez
2013-03-21 14:25 ` [patch] cilkplus array notation for C (clean, independent patchset, take 1) Aldy Hernandez
2013-03-21 19:08 ` Iyer, Balaji V
2013-03-21 23:30 ` Aldy Hernandez
2013-03-21 15:56 ` Joseph S. Myers
2013-03-22 22:04 ` Iyer, Balaji V
2013-03-25 16:45 ` Aldy Hernandez
2013-03-25 21:39 ` Iyer, Balaji V
2013-03-25 21:49 ` Aldy Hernandez
2013-03-26 17:05 ` Joseph S. Myers
2013-03-26 21:11 ` Iyer, Balaji V
2013-03-26 16:27 ` Joseph S. Myers
2013-03-21 16:48 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514B0657.3090802@redhat.com \
--to=aldyh@redhat.com \
--cc=balaji.v.iyer@intel.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).