From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22939 invoked by alias); 21 Mar 2013 23:34:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 22862 invoked by uid 89); 21 Mar 2013 23:33:57 -0000 X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 21 Mar 2013 23:33:54 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2LNXqrd027201 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 21 Mar 2013 19:33:52 -0400 Received: from houston.quesejoda.com (vpn-51-63.rdu2.redhat.com [10.10.51.63]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r2LNXp7G011812; Thu, 21 Mar 2013 19:33:51 -0400 Message-ID: <514B98DE.9070806@redhat.com> Date: Thu, 21 Mar 2013 23:34:00 -0000 From: Aldy Hernandez User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Mike Stump CC: Jakub Jelinek , Jeff Law , "Joseph S. Myers" , "Iyer, Balaji V" , gcc-patches Subject: Re: [patch] cilkplus array notation for C (clean, independent patchset, take 1) References: <5149D62F.9070503@redhat.com> <5149E4C7.1090206@redhat.com> <514A9B12.8050502@redhat.com> <20130321060933.GQ12913@tucnak.redhat.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-03/txt/msg00834.txt.bz2 On 03/21/13 11:54, Mike Stump wrote: > On Mar 20, 2013, at 11:09 PM, Jakub Jelinek wrote: >> On Wed, Mar 20, 2013 at 11:30:58PM -0600, Jeff Law wrote: >>> On 03/20/2013 10:33 AM, Aldy Hernandez wrote: >>>> As I'd mentioned, you have .exp files named compile.exp and execute.exp >>>> which seem to be causing ambiguity problems in parallel checks (make >>>> check -jN). For some reason, with this patch, the rest of dg.exp fails >>>> to run after Cilkplus' compile/execute.exp runs. Renaming these to >>>> something less generic does the trick. Do you mind prefixing all the >>>> .exp's with "cilkplus_" or something similar? >> >> Renaming is desirable anyway, > > So, the problem that causes it to not work needs to be fixed, before the patches go in. Renaming is a form of bug pushing and that can't be used to fix the problem. When the underlying problem is fixed, then rename, not before. The problem is that the entire sanity of the test suite depends critically on resetting the environment to be back the way it was upon the finishing of any particular .exp. You can run with -v -v -v -v and see check differences in the output, it might let you narrow down the issue. You can run env (or parry env) before and after, and quickly see if it is due to an environment variable. In theory, you can have tcl dump all the variables from the symbol tables, (info locals and info globals being the starting point)… but you'd need to differentiate between the variables that must be the same, and the variables that can be different. One might be able to turn on tracing to find it, though, that can make your eyes bleed. I can look into this later on, but this problem happened even when I replaced cilkplus' compile.exp, errors.exp, and execute.exp into just an "exit". So it seems unrelated to the cilk patchset.