From: Aldy Hernandez <aldyh@redhat.com>
To: "Iyer, Balaji V" <balaji.v.iyer@intel.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"Joseph Myers [joseph@codesourcery.com]"
<joseph@codesourcery.com>
Subject: Re: [patch] cilkplus array notation for C (clean, independent patchset, take 1)
Date: Mon, 25 Mar 2013 21:49:00 -0000 [thread overview]
Message-ID: <5150C679.5060509@redhat.com> (raw)
In-Reply-To: <BF230D13CA30DD48930C31D40993300016D7EC32@FMSMSX102.amr.corp.intel.com>
>>> The specification doesn't seem very clear on to what extent the __sec_*
>>> operations must act like functions (what happens if someone puts parentheses
>>> around the __sec_* name, for example - that wouldn't work with the keyword
>>> approach). So the specification should be clarified there, but I think saying the
>>> __sec_* operations are syntactically special, like keywords, is more appropriate
>>> than requiring other uses to work.
>>>
>>>> + return_int = (int) int_cst_value (fn_arg);
>>>> + else
>>>> + {
>>>> + if (location == UNKNOWN_LOCATION && EXPR_HAS_LOCATION (fn))
>>>> + location = EXPR_LOCATION (fn);
>>>> + error_at (location, "__sec_implicit_index parameter must be a "
>>>> + "constant integer expression");
>>>
>>> The term is "integer constant expression" not "constant integer expression".
>>
>> FIXED!
>
> ...it looks like you're going to have to rework all this as a keyword.
>
> OK, CAN I LOOK AT THIS AFTER WE FINISH THE BUILTIN FUNCTION IMPLEMENTATION FIX?
Yes.
Thank you for fixing everything I pointed out. Let's now wait for
Joseph to give the final ok. There are some things he suggested, that I
didn't look at at all, so I am deferring to him.
Thanks again.
next prev parent reply other threads:[~2013-03-25 21:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 15:32 Aldy Hernandez
2013-03-20 16:33 ` Aldy Hernandez
2013-03-20 22:28 ` Iyer, Balaji V
2013-03-21 12:55 ` Aldy Hernandez
2013-03-21 5:31 ` Jeff Law
2013-03-21 6:09 ` Jakub Jelinek
2013-03-21 13:01 ` Aldy Hernandez
2013-03-21 13:06 ` Iyer, Balaji V
2013-03-21 13:09 ` Aldy Hernandez
2013-03-21 13:15 ` Iyer, Balaji V
2013-03-21 16:54 ` Mike Stump
2013-03-21 23:34 ` Aldy Hernandez
2013-03-22 22:36 ` Mike Stump
2013-03-23 1:36 ` Iyer, Balaji V
2013-03-23 5:00 ` Mike Stump
2013-03-20 22:00 ` [cilkplus-merge] test for side effects Aldy Hernandez
2013-03-21 14:25 ` [patch] cilkplus array notation for C (clean, independent patchset, take 1) Aldy Hernandez
2013-03-21 19:08 ` Iyer, Balaji V
2013-03-21 23:30 ` Aldy Hernandez
2013-03-21 15:56 ` Joseph S. Myers
2013-03-22 22:04 ` Iyer, Balaji V
2013-03-25 16:45 ` Aldy Hernandez
2013-03-25 21:39 ` Iyer, Balaji V
2013-03-25 21:49 ` Aldy Hernandez [this message]
2013-03-26 17:05 ` Joseph S. Myers
2013-03-26 21:11 ` Iyer, Balaji V
2013-03-26 16:27 ` Joseph S. Myers
2013-03-21 16:48 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5150C679.5060509@redhat.com \
--to=aldyh@redhat.com \
--cc=balaji.v.iyer@intel.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).