From: Eric Botcazou <ebotcazou@adacore.com>
To: Richard Sandiford <rdsandiford@googlemail.com>
Cc: gcc-patches@gcc.gnu.org,
Andrew Pinski <andrew.pinski@caviumnetworks.com>,
Uros Bizjak <ubizjak@gmail.com>,
Paul_Koning@dell.com, kkojima@gcc.gnu.org, aoliva@redhat.com,
dje.gcc@gmail.com, uweigand@de.ibm.com, walt@tilera.com
Subject: Re: RFA: Simplifying truncation and integer lowpart subregs
Date: Sun, 07 Oct 2012 12:36:00 -0000 [thread overview]
Message-ID: <5155263.MbS9aEve2E@polaris> (raw)
In-Reply-To: <874nm6oe2n.fsf@talisman.home>
> Yeah, in hindsight, the patch was definitely lacking commentary.
> How about the patch below? It also fixes the partial int case
> and gets rid of the errant NOT hunk. Tested in the same way as before.
>
> Richard
>
>
> gcc/
> * machmode.h (GET_MODE_UNIT_PRECISION): New macro.
> * simplify-rtx.c (simplify_truncation): New function,
> extracted from simplify_subreg and (in small part) from
> simplify_unary_operation_1.
> (simplify_unary_operation_1) <TRUNCATE>: Use it. Remove sign bit
> test for !TRULY_NOOP_TRUNCATION_MODES_P.
> (simplify_subreg): Use simplify_truncate for lowpart subregs
> where both the inner and outer modes are scalar integers.
This looks good to me, thanks.
--
Eric Botcazou
next prev parent reply other threads:[~2012-10-07 12:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 8:04 [PATCH, rtl-optimization]: Fix PR54457, [x32] Fail to combine 64bit index + constant Uros Bizjak
2012-09-26 18:17 ` Richard Sandiford
2012-09-26 21:38 ` Eric Botcazou
2012-09-27 14:25 ` Uros Bizjak
2012-09-27 16:10 ` Richard Sandiford
2012-09-27 18:20 ` [PATCH v2, " Uros Bizjak
2012-09-27 18:35 ` Paul_Koning
2012-09-27 19:21 ` Uros Bizjak
2012-10-02 2:13 ` Andrew Pinski
2012-10-02 19:32 ` Richard Sandiford
2012-10-06 10:22 ` RFA: Simplifying truncation and integer lowpart subregs Richard Sandiford
2012-10-06 11:13 ` Eric Botcazou
2012-10-06 12:39 ` Richard Sandiford
2012-10-06 13:05 ` Eric Botcazou
2012-10-07 8:56 ` Richard Sandiford
2012-10-07 12:36 ` Eric Botcazou [this message]
2012-11-28 2:27 ` Ramana Radhakrishnan
2012-11-28 21:45 ` Richard Sandiford
2012-09-27 20:33 ` [PATCH v2, rtl-optimization]: Fix PR54457, [x32] Fail to combine 64bit index + constant Jakub Jelinek
2012-09-27 22:37 ` Richard Sandiford
2012-09-28 15:39 ` Uros Bizjak
2012-09-30 11:40 ` Richard Sandiford
2012-10-03 11:07 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5155263.MbS9aEve2E@polaris \
--to=ebotcazou@adacore.com \
--cc=Paul_Koning@dell.com \
--cc=andrew.pinski@caviumnetworks.com \
--cc=aoliva@redhat.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kkojima@gcc.gnu.org \
--cc=rdsandiford@googlemail.com \
--cc=ubizjak@gmail.com \
--cc=uweigand@de.ibm.com \
--cc=walt@tilera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).