From: Ramana Radhakrishnan <ramrad01@arm.com>
To: Greta Yorsh <Greta.Yorsh@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
"nickc@redhat.com" <nickc@redhat.com>,
"paul@codesourcery.com" <paul@codesourcery.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH,ARM][1/n] New patterns for subtract with carry
Date: Fri, 05 Apr 2013 18:59:00 -0000 [thread overview]
Message-ID: <515EEEB4.1090503@arm.com> (raw)
In-Reply-To: <B393A6715F47FC43935D96EA15105EFF3F95D287B4@GEORGE.Emea.Arm.com>
On 04/05/13 16:26, Greta Yorsh wrote:
>
>> -----Original Message-----
>> From: Richard Earnshaw
>> Sent: 22 February 2013 16:30
>> To: Greta Yorsh
>> Cc: GCC Patches; Ramana Radhakrishnan; nickc@redhat.com;
>> paul@codesourcery.com
>> Subject: Re: [PATCH,ARM][1/n] New patterns for subtract with carry
>>
>> On 18/02/13 18:35, Greta Yorsh wrote:
>>> Add patterns to handle various subtract with carry operations.
>>>
>>> These patterns match RTL insns emitted by splitters
>>> for DImode operations such as subdi, negdi, and cmpdi.
>>>
>>> gcc/
>>>
>>> 2013-02-14 Greta Yorsh <Greta.Yorsh@arm.com>
>>>
>>> * config/arm/arm.md (subsi3_carryin, subsi3_carryin_const):
>> New
>>> patterns.
>>> (subsi3_carryin_compare,subsi3_carryin_compare_const):
>> Likewise.
>>> (subsi3_carryin_shift,rsbsi3_carryin_shift): Likewise.
>>>
>>>
>>
>> Not ok. RSC does not exist in Thumb state.
>>
>> R.
>
> I'm attaching an updated patch. I changed the condition of rsbsi3_carryin_shift pattern and added "arch" attribute to subsi3_carryin as appropriate.
>
> I have also tested the patch again on the recent trunk along with all other patching in this series, which have already been approved. No regressions.
>
> Ok for trunk?
>
Ok
ramana
next prev parent reply other threads:[~2013-04-05 15:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 18:30 [PATCH, ARM][0/n] Split patterns that output multiple assembly instruction Greta Yorsh
2013-02-18 18:35 ` [PATCH,ARM][1/n] New patterns for subtract with carry Greta Yorsh
2013-02-22 16:29 ` Richard Earnshaw
[not found] ` <B393A6715F47FC43935D96EA15105EFF3F95D287B4@GEORGE.Emea.Arm.com>
2013-04-05 18:59 ` Ramana Radhakrishnan [this message]
2013-02-18 18:37 ` [PATCH,ARM][2/n] Split subdi patterns Greta Yorsh
2013-02-22 16:33 ` Richard Earnshaw
2013-02-18 18:39 ` [PATCH,ARM][3/n] Split various patterns Greta Yorsh
2013-04-09 18:13 ` Richard Earnshaw
2013-02-18 18:41 ` [PATCH,ARM][4/n] Add negdi_extend patterns Greta Yorsh
2013-02-18 18:43 ` [PATCH,ARM][5/n] Split shift di patterns Greta Yorsh
2013-02-18 18:45 ` [PATCH,ARM][6/n] Split min and max patterns Greta Yorsh
2013-04-09 18:02 ` Richard Earnshaw
2013-02-18 18:46 ` [PATCH, ARM][7/n] Comment on splitting THUMB1 patterns Greta Yorsh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515EEEB4.1090503@arm.com \
--to=ramrad01@arm.com \
--cc=Greta.Yorsh@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nickc@redhat.com \
--cc=paul@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).