From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29641 invoked by alias); 5 Apr 2013 15:37:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 28418 invoked by uid 89); 5 Apr 2013 15:33:18 -0000 X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 05 Apr 2013 15:33:13 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Fri, 05 Apr 2013 16:33:10 +0100 Received: from [10.1.69.70] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Fri, 5 Apr 2013 16:33:09 +0100 Message-ID: <515EEEB4.1090503@arm.com> Date: Fri, 05 Apr 2013 18:59:00 -0000 From: Ramana Radhakrishnan User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: Greta Yorsh CC: GCC Patches , "nickc@redhat.com" , "paul@codesourcery.com" , Richard Earnshaw Subject: Re: [PATCH,ARM][1/n] New patterns for subtract with carry References: <001101ce0e05$f5928a50$e0b79ef0$@yorsh@arm.com> <001301ce0e06$bbd193f0$3374bbd0$@yorsh@arm.com> <51279CF4.3010809@arm.com> In-Reply-To: X-MC-Unique: 113040516331002801 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-04/txt/msg00336.txt.bz2 On 04/05/13 16:26, Greta Yorsh wrote: > >> -----Original Message----- >> From: Richard Earnshaw >> Sent: 22 February 2013 16:30 >> To: Greta Yorsh >> Cc: GCC Patches; Ramana Radhakrishnan; nickc@redhat.com; >> paul@codesourcery.com >> Subject: Re: [PATCH,ARM][1/n] New patterns for subtract with carry >> >> On 18/02/13 18:35, Greta Yorsh wrote: >>> Add patterns to handle various subtract with carry operations. >>> >>> These patterns match RTL insns emitted by splitters >>> for DImode operations such as subdi, negdi, and cmpdi. >>> >>> gcc/ >>> >>> 2013-02-14 Greta Yorsh >>> >>> * config/arm/arm.md (subsi3_carryin, subsi3_carryin_const): >> New >>> patterns. >>> (subsi3_carryin_compare,subsi3_carryin_compare_const): >> Likewise. >>> (subsi3_carryin_shift,rsbsi3_carryin_shift): Likewise. >>> >>> >> >> Not ok. RSC does not exist in Thumb state. >> >> R. > > I'm attaching an updated patch. I changed the condition of rsbsi3_carryin= _shift pattern and added "arch" attribute to subsi3_carryin as appropriate. > > I have also tested the patch again on the recent trunk along with all oth= er patching in this series, which have already been approved. No regression= s. > > Ok for trunk? > Ok ramana