From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by sourceware.org (Postfix) with ESMTPS id 6FEEC385800F for ; Wed, 31 Aug 2022 20:36:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6FEEC385800F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pj1-x102c.google.com with SMTP id u9-20020a17090a1f0900b001fde6477464so395715pja.4 for ; Wed, 31 Aug 2022 13:36:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=dEOU0/S78ndpVpUzFSLe5m/8W5UQW+j2v75CYnnsMiA=; b=xl+3srkK17fJbiQ69LeIi4yRBvuoe/8NvVO3bsGz7pE4g+ldCyUyvaFXtCAiQLQSIN 8pxvWWngBpubTGjchYL41bUD0o5yUbMRtmnyCNokvhsvkxedqF9AlLYIXz1dOTx2sERb UxvkcKqtM5BgxuED/4ePEglPFVDGH5rLMHB0+sdlpM7ZvtDfvZqiF4zf1NQ87Do+0VuD ZVYWwlLVOuMhOEPSlFAfTlgsmCjCCOVit3euKiLpN6uv+RFQm1idD25yPQJVN73tLMXv 9ZDLPSRw7ENAOU82NKXnhMaajjjLPUgiJuvqykjfX3R2DfkGYokDeCVoXCGaNruAi6Vx 0jDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=dEOU0/S78ndpVpUzFSLe5m/8W5UQW+j2v75CYnnsMiA=; b=JiAcPL9jYf13Hj/+EFELoA3eh8pu84knSui9Jfn8H7HcdJfe7+51HJDA3JULQ3F+li pQba71yky9MDlPP3buxX/uXJaEi8A5c83StWcNkmN9AZiphhSK10qw4wlSiR+zpt/oLz zvATI5CJcgkAc+yoRqJipGmpFd8dcMSR5fYZD1Xv2KAgZ1NvM4m/waKhkCCzzqfY24qH +OClE1DpdpCEp+Atg8Hgbg9oxXt/yPbOW/RLmEuOuXYXxaAn2XZV5xhx/30cDRByIAVA iyF8QoM6byiuOrHvEpT4Nk/QD7/Vol0IgpqpJ3+83b486J/cAfW64XputWJZSOnnZkov BrEQ== X-Gm-Message-State: ACgBeo2e8umWlvGgvlXUtFEMf5p4+P608HKxbO5EQtotKb/Mj/xTAijC LwYBt5fMa5ZM+5HcT1169KLKxw== X-Google-Smtp-Source: AA6agR7ZtjnEgl7rKU7YdAJlGSsWE+34ve6yckWehdjVv1sOhJdm+dx6kj90NtL9qfRr5k4x+5mzKA== X-Received: by 2002:a17:902:eccb:b0:174:5227:ace6 with SMTP id a11-20020a170902eccb00b001745227ace6mr23854006plh.18.1661978208526; Wed, 31 Aug 2022 13:36:48 -0700 (PDT) Received: from [192.168.50.116] (c-24-4-73-83.hsd1.ca.comcast.net. [24.4.73.83]) by smtp.gmail.com with ESMTPSA id it6-20020a17090afb0600b001fba4716f11sm1746615pjb.22.2022.08.31.13.36.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Aug 2022 13:36:47 -0700 (PDT) Message-ID: <51722bee-6d84-f92b-0025-e216be931a6a@rivosinc.com> Date: Wed, 31 Aug 2022 13:36:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/2] RISC-V: remove deprecate pic code model macro Content-Language: en-US To: Palmer Dabbelt Cc: gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , philipp.tomsich@vrull.eu, christoph.muellner@vrull.eu, collison@rivosinc.com, gnu-toolchain@rivosinc.com References: From: Vineet Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/31/22 07:57, Palmer Dabbelt wrote: > On Tue, 30 Aug 2022 10:48:29 PDT (-0700), Vineet Gupta wrote: >> Came across this deprecated symbol when looking around for >> -mexplicit-relocs handling in code >> >> Signed-off-by: Vineet Gupta >> --- >>  gcc/config/riscv/riscv-c.cc | 3 --- >>  1 file changed, 3 deletions(-) >> >> diff --git a/gcc/config/riscv/riscv-c.cc b/gcc/config/riscv/riscv-c.cc >> index eb7ef09297e9..bba72cf77a82 100644 >> --- a/gcc/config/riscv/riscv-c.cc >> +++ b/gcc/config/riscv/riscv-c.cc >> @@ -93,9 +93,6 @@ riscv_cpu_cpp_builtins (cpp_reader *pfile) >>        break; >> >>      case CM_PIC: >> -      /* __riscv_cmodel_pic is deprecated, and will removed in next >> GCC release. >> -     see https://github.com/riscv/riscv-c-api-doc/pull/11  */ >> -      builtin_define ("__riscv_cmodel_pic"); >>        /* FALLTHROUGH. */ >> >>      case CM_MEDANY: > > It looks like some of the tests > (gcc/testsuite/gcc.target/riscv/predef-3.c, for example) are checking > for __riscv_cmodel_pic.  From looking at them I'd expect them to fail, > but even if they're not we should clean them up. Aah, I did miss removing them and looks like there was a snafu in my test setup as well. I'm rerunning the tests with the fix and will post a v2 after tests come out clean. Thx, -Vineet