From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 9B8483858D28; Wed, 21 Jun 2023 16:20:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9B8483858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35LGGU04018907; Wed, 21 Jun 2023 16:20:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=g1953yJXQeqj+IMVRUPIihh8jS4kwCePxhHFcDShuuQ=; b=BkqN+U/e+FcCNrhsVDjuSsomLGwdQa3UFyZ2y8l9aHYiJBtfR7zMLLdhjAgGPPb1Hoxu QAAF3u03ZnOfVqrJs2AG34VS6kMHQAEl5EhKNigITJ3u9SkaweDU6ieRW8606j9LVUkG eaE++iSH26Bbp1g4BcBY/WNN0Iv74QlEgiKQ1Es9G5yD+2RmqJVRN8CTQjSpYkRpaXc6 Lflg3kGtCq/QcBu1uRKMWIjOu9S76H+dD7bSIoHUHT/b9oTD7jrHFtSIj80BA5BYLBsy 8eYOTXatzCJnQTtl4/Lf5nnuuUr8Pf6AvjgbCXTysrkJsq6NEjY8GxYiVGl+lL35qi4M 6w== Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rc38hk3ue-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Jun 2023 16:20:49 +0000 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35LGHag1023869; Wed, 21 Jun 2023 16:20:48 GMT Received: from smtprelay03.wdc07v.mail.ibm.com ([9.208.129.113]) by ppma04wdc.us.ibm.com (PPS) with ESMTPS id 3r94f5w2kc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Jun 2023 16:20:48 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35LGKlZx66978164 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Jun 2023 16:20:47 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 19EDD58056; Wed, 21 Jun 2023 16:20:47 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A4A6758062; Wed, 21 Jun 2023 16:20:46 +0000 (GMT) Received: from [9.67.100.162] (unknown [9.67.100.162]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 21 Jun 2023 16:20:46 +0000 (GMT) Message-ID: <517783a6-4ce8-77af-6e16-bf49205eec02@linux.ibm.com> Date: Wed, 21 Jun 2023 11:20:46 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/2] rust: update usage of TARGET_AIX to TARGET_AIX_OS To: Thomas Schwinge Cc: gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org References: <20230616160002.1854983-1-murphyp@linux.ibm.com> <20230616160002.1854983-2-murphyp@linux.ibm.com> <87a5wv3kxd.fsf@euler.schwinge.homeip.net> Content-Language: en-US From: Paul E Murphy In-Reply-To: <87a5wv3kxd.fsf@euler.schwinge.homeip.net> Content-Type: text/plain; charset=UTF-8; format=flowed X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: kXzPPhg4rLddd4iAPnJUpJMpdRJTUYA3 X-Proofpoint-GUID: kXzPPhg4rLddd4iAPnJUpJMpdRJTUYA3 Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-21_09,2023-06-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 impostorscore=0 spamscore=0 suspectscore=0 mlxlogscore=953 lowpriorityscore=0 bulkscore=0 mlxscore=0 malwarescore=0 adultscore=0 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306210135 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/19/23 3:39 AM, Thomas Schwinge wrote: > Hi Paul! > > On 2023-06-16T11:00:02-0500, "Paul E. Murphy via Gcc-patches" wrote: >> This was noticed when fixing the gccgo usage of the macro, the >> rust usage is very similar. >> >> TARGET_AIX is defined as a non-zero value on linux/powerpc64le >> which may cause unexpected behavior. TARGET_AIX_OS should be >> used to toggle AIX specific behavior. >> >> gcc/rust/ChangeLog: >> >> * rust-object-export.cc [TARGET_AIX]: Rename and update >> usage to TARGET_AIX_OS. > > I don't have rights to formally approve this GCC/Rust change, but I'll > note that it follows "as obvious" (see > , "Obvious fixes") to the > corresponding GCC/Go change, which has been approved: > , > and which is where this GCC/Rust code has been copied from, so I suggest > you push both patches at once. > > > Grüße > Thomas Hi Thomas, Thank you for reviewing. I do not have commit access, so I cannot push this myself. If this is OK, could one of the rust maintainers push this patch? Thanks, Paul