From: Lulu Cheng <chenglulu@loongson.cn>
To: Xi Ruoyao <xry111@xry111.site>, gcc-patches@gcc.gnu.org
Cc: i@xen0n.name, xuchenghua@loongson.cn
Subject: Re: [PATCH] LoongArch: Remove the definition of the macro LOGICAL_OP_NON_SHORT_CIRCUIT under the architecture and use the default definition instead.
Date: Thu, 13 Apr 2023 20:30:34 +0800 [thread overview]
Message-ID: <51862d0e-c8e7-b62b-a08b-d58427c6f66c@loongson.cn> (raw)
In-Reply-To: <e530ba250c7e8bc28d99c59c9614fbec53aca7fc.camel@xry111.site>
在 2023/4/13 下午8:24, Xi Ruoyao 写道:
> On Thu, 2023-04-13 at 19:51 +0800, Lulu Cheng wrote:
>> In some cases, setting this macro as the default can reduce the number of conditional
>> branch instructions.
>>
>> gcc/ChangeLog:
>>
>> * config/loongarch/loongarch.h (LOGICAL_OP_NON_SHORT_CIRCUIT): Remove the macro
>> definition.
> I think it's OK for GCC 13. At least the result is better for simple
> cases like "x >= a && x < b".
I also want to merge to GCC13.:-D
>
>> ---
>> gcc/config/loongarch/loongarch.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/gcc/config/loongarch/loongarch.h b/gcc/config/loongarch/loongarch.h
>> index f8167875646..6b7dbecd3ff 100644
>> --- a/gcc/config/loongarch/loongarch.h
>> +++ b/gcc/config/loongarch/loongarch.h
>> @@ -836,7 +836,6 @@ typedef struct {
>> 1 is the default; other values are interpreted relative to that. */
>>
>> #define BRANCH_COST(speed_p, predictable_p) loongarch_branch_cost
>> -#define LOGICAL_OP_NON_SHORT_CIRCUIT 0
>>
>> /* Return the asm template for a conditional branch instruction.
>> OPCODE is the opcode's mnemonic and OPERANDS is the asm template for
next prev parent reply other threads:[~2023-04-13 12:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 11:51 Lulu Cheng
2023-04-13 12:24 ` Xi Ruoyao
2023-04-13 12:30 ` Lulu Cheng [this message]
2023-04-18 1:54 ` [pushed][PATCH] " Lulu Cheng
2023-04-18 6:35 ` Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51862d0e-c8e7-b62b-a08b-d58427c6f66c@loongson.cn \
--to=chenglulu@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=i@xen0n.name \
--cc=xry111@xry111.site \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).