public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Paolo Carlini <paolo.carlini@oracle.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
	       gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: Unordered container insertion hints
Date: Thu, 23 May 2013 23:00:00 -0000	[thread overview]
Message-ID: <519E9F88.3010309@oracle.com> (raw)
In-Reply-To: <519E75B2.4040000@gmail.com>

On 05/23/2013 10:01 PM, François Dumont wrote:
> Some feedback regarding this patch ?
Two quick ones: what if the hint is wrong? I suppose the insertion 
succeeds anyway, it's only a little waste of time, right? Is it possible 
that for instance something throws in that case and would not now (when 
the hint is simply ignored)? In case, check and re-check we are still 
conforming.

In any case, I think it's quite easy to notice if an implementation is 
using the hint in this way or a similar one basing on some simple 
benchmarks, without looking of course at the actual implementation code. 
Do we have any idea what other implementations are doing? Like, eg, they 
invented something for unordered_set and map too? Or a better way to 
exploit the hint for the multi variants? Eventually I suppose we want to 
add a performance testcase to our testsuite.

Thanks!
Paolo.

  reply	other threads:[~2013-05-23 23:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-15 19:49 François Dumont
2013-05-23 20:02 ` François Dumont
2013-05-23 23:00   ` Paolo Carlini [this message]
2013-06-06 20:33     ` François Dumont
2013-06-12 20:12       ` François Dumont
2013-06-19 19:56         ` François Dumont
2013-06-23 12:52           ` Jonathan Wakely
2013-06-28 12:13             ` Jonathan Wakely
2013-06-29 12:16               ` François Dumont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=519E9F88.3010309@oracle.com \
    --to=paolo.carlini@oracle.com \
    --cc=frs.dumont@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).