From: Jason Merrill <jason@redhat.com>
To: Gabriel Dos Reis <gdr@integrable-solutions.net>,
Oleg Endo <oleg.endo@t-online.de>
Cc: Andrew Sutton <andrew.n.sutton@gmail.com>,
gcc-patches@gcc.gnu.org, Benjamin Kosnik <bkoz@redhat.com>,
Lawrence Crowl <crowl@google.com>,
Diego Novillo <dnovillo@google.com>
Subject: Re: [c++-concepts] code review
Date: Mon, 10 Jun 2013 16:14:00 -0000 [thread overview]
Message-ID: <51B5FB53.4070401@redhat.com> (raw)
In-Reply-To: <CAAiZkiCsA8jxMufRnmoUYOT5BbUDfPzX2NKJkrh-bywkobnmng@mail.gmail.com>
On 06/09/2013 08:34 PM, Gabriel Dos Reis wrote:
> I strongly suggest prefering <stdlib.h> over <cstdlib> for GCC source code
> base.
The problem is that including <stdlib.h> does not define
_GLIBCXX_CSTDLIB, so if one of the C++ library headers includes
<cstdlib> the contents are added then, but by that point e.g. "malloc"
is poisoned, so the mentions of malloc in cstdlib cause errors.
Because we are poisoning these names, we need to #include *both* headers
in system.h.
Jason
next prev parent reply other threads:[~2013-06-10 16:14 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 14:07 [c++-concepts] Reserving new keywords for concepts Andrew Sutton
2013-02-28 14:51 ` Gabriel Dos Reis
2013-02-28 15:01 ` Andrew Sutton
2013-02-28 15:11 ` Gabriel Dos Reis
2013-02-28 15:54 ` Andrew Sutton
2013-02-28 15:57 ` Gabriel Dos Reis
2013-06-06 15:55 ` [c++-concepts] code review Jason Merrill
2013-06-06 17:48 ` Andrew Sutton
2013-06-06 20:29 ` Jason Merrill
2013-06-08 13:35 ` Andrew Sutton
2013-06-10 0:49 ` Gabriel Dos Reis
2013-06-10 16:27 ` Jason Merrill
2013-06-10 19:30 ` Jason Merrill
2013-06-11 13:45 ` Andrew Sutton
2013-06-11 14:27 ` Jason Merrill
2013-06-11 14:49 ` Andrew Sutton
2013-06-11 15:00 ` Jason Merrill
2013-06-11 15:09 ` Andrew Sutton
2013-06-11 17:54 ` Jason Merrill
2013-06-12 15:53 ` Gabriel Dos Reis
2013-06-12 16:35 ` Jason Merrill
2013-06-14 15:32 ` Andrew Sutton
2013-06-15 1:40 ` Jason Merrill
2013-06-15 2:13 ` Gabriel Dos Reis
2013-06-17 18:11 ` Andrew Sutton
2013-06-17 19:20 ` Jason Merrill
2013-06-18 0:29 ` Gabriel Dos Reis
2013-06-18 16:28 ` Andrew Sutton
2013-06-19 14:21 ` Jason Merrill
2013-06-19 16:10 ` Andrew Sutton
2013-06-20 5:30 ` Gabriel Dos Reis
2013-06-20 13:01 ` Jason Merrill
2013-06-20 13:09 ` Gabriel Dos Reis
2013-06-20 13:19 ` Andrew Sutton
2013-06-20 13:57 ` Jason Merrill
2013-06-20 14:18 ` Andrew Sutton
2013-06-20 15:17 ` Jason Merrill
2013-06-20 15:22 ` Gabriel Dos Reis
2013-06-20 15:27 ` Jason Merrill
2013-06-20 15:29 ` Gabriel Dos Reis
2013-06-20 15:50 ` Andrew Sutton
2013-06-20 17:23 ` Jason Merrill
2013-06-20 18:33 ` Jason Merrill
2013-06-21 12:46 ` Andrew Sutton
2013-06-24 15:55 ` Jason Merrill
2013-06-20 15:20 ` Gabriel Dos Reis
2013-06-09 20:34 ` Oleg Endo
2013-06-10 0:34 ` Gabriel Dos Reis
2013-06-10 14:51 ` Diego Novillo
2013-06-10 22:51 ` Lawrence Crowl
2013-06-10 16:14 ` Jason Merrill [this message]
2015-05-01 18:32 Jason Merrill
2015-05-01 19:21 ` Andrew Sutton
2015-05-08 20:08 ` Andrew Sutton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B5FB53.4070401@redhat.com \
--to=jason@redhat.com \
--cc=andrew.n.sutton@gmail.com \
--cc=bkoz@redhat.com \
--cc=crowl@google.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdr@integrable-solutions.net \
--cc=oleg.endo@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).