From: Tobias Burnus <burnus@net-b.de>
To: Mikael Morin <mikael.morin@sfr.fr>
Cc: gcc patches <gcc-patches@gcc.gnu.org>, gfortran <fortran@gcc.gnu.org>
Subject: Re: [Patch, Fortran] PR57508 - Fix ICE/Reject-valid issue with get_temp_from_expr (intrinsic assignment with defined assignment)
Date: Thu, 13 Jun 2013 17:56:00 -0000 [thread overview]
Message-ID: <51BA07BE.4090205@net-b.de> (raw)
In-Reply-To: <51B441D6.9030200@sfr.fr>
Mikael Morin wrote:
> This fixes the problem, but shouldn't the fix be in gfc_expr_attr instead?
I tried it - but it does not work: In many case, one actually needs a
function, e.g. for procedure pointers or for C_FUNLOC. Thus, I had to
add an additional flag to tell whether the function or the function
result it needed. But instead of adding a Boolean flag to 55 calls,
which can be false in 54 case and true in 1, I think that the original
patch is better. It's the only case where not an attribute it checked -
but where attributes are copied.
Thus, is the original patch okay? Or do you have a better
proposal?http://gcc.gnu.org/ml/fortran/2013-06/msg00027.html
Tobias
PS: Other pending patches:
* Unreviewed: Print exception status at STOP,
http://gcc.gnu.org/ml/fortran/2013-06/msg00077.html
* PR57596 - Fix OPTIONAL handling of deferred-length strings,
http://gcc.gnu.org/ml/fortran/2013-06/msg00082.html
next prev parent reply other threads:[~2013-06-13 17:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 14:06 Tobias Burnus
2013-06-06 8:27 ` *ping* / " Tobias Burnus
2013-06-09 8:51 ` Mikael Morin
2013-06-11 10:01 ` Tobias Burnus
2013-06-11 11:00 ` Mikael Morin
2013-06-13 17:56 ` Tobias Burnus [this message]
2013-06-14 11:09 ` Mikael Morin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BA07BE.4090205@net-b.de \
--to=burnus@net-b.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikael.morin@sfr.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).