Re: [c++-concepts] code review

[Jason Merrill <jason@redhat.com>]

On 06/20/2013 11:50 AM, Andrew Sutton wrote:
>> The c++-concepts SVN branch won't come in with a clone; you need to add it
>> to the fetch list with
>>
>> git config --add remote.origin.fetch
>> refs/remotes/c++-concepts:refs/remotes/origin/c++-concepts
>>
>> Then you can check out a local branch based on it.
>
> Already did that. I probably need to do this, right?
>
>    git checkout -b c++-concepts origin/c++-concepts

Right.

> I just setup using a git-only branch, so the latter. I set up to push
> changes to asutton/c++-concepts, so submitted should be visible there.

Since Gaby prefers SVN, let's keep using the SVN branch; it really isn't 
much less convenient than a git-only branch.  The main difference is 
'git svn rebase'/'git svn dcommit' instead of 'git pull'/'git push'.

> Out of curiosity, how will reviews work? Just walk through the most
> recently pushed changes on my branch?

That's what I was thinking, yes.

> I should be able to produce diffs to send to Gaby also. I should also
> be able to use those to patch an SVN checkout and commit from a
> different repo.

git-svn is much more convenient :)

Jason