From: Michael Eager <eager@eagerm.com>
To: David Holsgrove <david.holsgrove@xilinx.com>
Cc: Chung-Ju Wu <jasonwucj@gmail.com>,
Eric Botcazou <ebotcazou@adacore.com>,
gcc-patches@gcc.gnu.org, Edgar Iglesias <edgari@xilinx.com>,
John Williams <jwilliams@xilinx.com>,
Vinod Kathail <vinodk@xilinx.com>,
Vidhumouli Hunsigida <vidhum@xilinx.com>,
Nagaraju Mekala <nmekala@xilinx.com>, Tom Shui <tshui@xilinx.com>
Subject: Re: [Patch, microblaze]: Add -fstack-usage support
Date: Tue, 23 Jul 2013 21:23:00 -0000 [thread overview]
Message-ID: <51EEF2CD.7080407@eagerm.com> (raw)
In-Reply-To: <CAM=EW8bEJjRG_uWpPvRO_1ms0uj-ufAOWFAQCuMayJEsZ7Uuyw@mail.gmail.com>
On 07/22/13 22:50, David Holsgrove wrote:
> Hi Eric / Chung-Ju,
>
> On 21 July 2013 01:33, Chung-Ju Wu <jasonwucj@gmail.com> wrote:
>> On 7/20/13 4:14 PM, Eric Botcazou wrote:
>>>>>
>>>>> 2013-03-18 David Holsgrove <david.holsgrove@xilinx.com>
>>>>>
>>>>> * gcc/config/microblaze/microblaze.c (microblaze_expand_prologue):
>>>>> Add check for flag_stack_usage to handle -fstack-usage support
>>>>>
>>>>> Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
>>>>
>>>>
>>>> Patch remains the same, please apply when ready.
>>>
>>>
>>> The patch is incorrect, please adjust it to match the other architectures.
>>>
>>
>> Hi, David,
>>
>> Specifically speaking, what Eric meant is to check
>> flag_stack_usage_info rather than flag_stack_usage
>> due to the changes after gcc-4.7.
>>
>
> Ah, thanks for the catch - patch had been sitting in my tree for quite a while,
> hadn't realised the variable name had changed on trunk.
>
> Patch attached which adjusts microblaze's usage to align with other archs.
Committed revision 201186.
Please send an updated ChangeLog when it is different from the
original.
ChangeLog:
2013-07-23 David Holsgrove <david.holsgrove@xilinx.com>
* config/microblaze/microblaze.c (microblaze_expand_prologue):
Rename flag_stack_usage to flag_stack_usage_info.
--
Michael Eager eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
next prev parent reply other threads:[~2013-07-23 21:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 12:49 David Holsgrove
2013-07-15 4:50 ` David Holsgrove
2013-07-20 8:20 ` Eric Botcazou
2013-07-20 16:45 ` Chung-Ju Wu
2013-07-23 7:18 ` David Holsgrove
2013-07-23 21:23 ` Michael Eager [this message]
2013-07-18 16:45 ` Michael Eager
2013-07-18 23:58 ` David Holsgrove
2013-07-19 4:14 ` Michael Eager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EEF2CD.7080407@eagerm.com \
--to=eager@eagerm.com \
--cc=david.holsgrove@xilinx.com \
--cc=ebotcazou@adacore.com \
--cc=edgari@xilinx.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jasonwucj@gmail.com \
--cc=jwilliams@xilinx.com \
--cc=nmekala@xilinx.com \
--cc=tshui@xilinx.com \
--cc=vidhum@xilinx.com \
--cc=vinodk@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).