From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76538 invoked by alias); 6 Sep 2016 17:34:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 76524 invoked by uid 89); 6 Sep 2016 17:34:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=feet, states X-HELO: resqmta-po-01v.sys.comcast.net Received: from resqmta-po-01v.sys.comcast.net (HELO resqmta-po-01v.sys.comcast.net) (96.114.154.160) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Sep 2016 17:34:21 +0000 Received: from resomta-po-04v.sys.comcast.net ([96.114.154.228]) by resqmta-po-01v.sys.comcast.net with SMTP id hKFQbR3erucHZhKGJbVkPj; Tue, 06 Sep 2016 17:34:19 +0000 Received: from up.mrs.kithrup.com ([24.4.193.248]) by resomta-po-04v.sys.comcast.net with SMTP id hKGHb7Yw9YCU0hKGIb3ZLn; Tue, 06 Sep 2016 17:34:19 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH 3/4][PR 71931] Fix libitm tests From: Mike Stump In-Reply-To: <1473153065.20286.30.camel@localhost.localdomain> Date: Tue, 06 Sep 2016 18:06:00 -0000 Cc: Szabolcs Nagy , nd , "gcc-patches@gcc.gnu.org" Content-Transfer-Encoding: quoted-printable Message-Id: <51FF09E9-0BA6-4592-A919-4FE1C4982B76@comcast.net> References: <57BDEFC5.4050207@arm.com> <57BDF0BA.5070303@arm.com> <1473153065.20286.30.camel@localhost.localdomain> To: Torvald Riegel X-CMAE-Envelope: MS4wfA3UIvL/hyWHULTynLkUk5Hp3hUQ6OE08X9JIxxie2o5p1Fur7L2GWibjIs8wyzi04N1u0/l2FgLESAd9yPCoxgGcAJXAnQnLyuCkLC8bgQZNt4gpWTZ 8gEkgJQPJwO/F7wGm+DlrcFx2BRlc+YqJVdxT0qMd/fQ6yzj7NnE7KD2f/wPcpfw4jXeRB25BAPzqVo1fvHPOanH8Icoj5gaE+JHrgo9A90EGDUEv00FM8/1 QPPVCMuzskMOMxg07dUJVvk2r0vxyM+x8VXS4Rd7Z4o= X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00323.txt.bz2 On Sep 6, 2016, at 2:11 AM, Torvald Riegel wrote: >=20 > On Wed, 2016-08-24 at 20:08 +0100, Szabolcs Nagy wrote: >> Pass build time CC make var down to dejagnu so the sysroot >> is set correctly when gcc is built with --with-build-sysroot. >>=20 >> libitm/ >> 2016-08-24 Szabolcs Nagy >>=20 >> PR testsuite/71931 >> * configure.ac: Add AC_CONFIG_FILES. >> * configure: Regenerated. >> * testuite/Makefile.am: Add rule for libitm-test-support.exp. >> * testuite/Makefile.in: Regenerated. >> * testuite/libitm-test-support.exp.in: New. >> * testuite/lib/libitm.exp (libitm_init): Use BUILD_CC. >>=20 >=20 > I don't know enough about the build system to really review this. If a > similar patch has been ACKed and applied for libatomic (71931 states > that both are affected), then I guess this is OK? I was hoping that someone else might review it, but i can see why no one el= se can or wants to. Sorry for the feet dragging, Ok. If libatomic has the same problem, and a = similar solutions works there, Ok to fix it as well. If someone wants to do a little work to make fortran libstdc++ and the othe= r two use the same mechanism, that would be nice.