From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-473618-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 35952 invoked by alias); 20 Feb 2018 18:59:42 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 35931 invoked by uid 89); 20 Feb 2018 18:59:41 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=20022018, habits, 20.02.2018, Hx-languages-length:524
X-Spam-User: qpsmtpd, 2 recipients
X-HELO: cc-smtpout1.netcologne.de
Received: from cc-smtpout1.netcologne.de (HELO cc-smtpout1.netcologne.de) (89.1.8.211) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Feb 2018 18:59:39 +0000
Received: from cc-smtpin3.netcologne.de (cc-smtpin3.netcologne.de [89.1.8.203])	by cc-smtpout1.netcologne.de (Postfix) with ESMTP id 75D63135D9;	Tue, 20 Feb 2018 19:59:37 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])	by cc-smtpin3.netcologne.de (Postfix) with ESMTP id 7104811D9B;	Tue, 20 Feb 2018 19:59:37 +0100 (CET)
Received: from [78.35.157.23] (helo=cc-smtpin3.netcologne.de)	by localhost with ESMTP (eXpurgate 4.1.9)	(envelope-from <tkoenig@netcologne.de>)	id 5a8c7019-02b7-7f0000012729-7f000001edf7-1	for <multiple-recipients>; Tue, 20 Feb 2018 19:59:37 +0100
Received: from [192.168.178.20] (xdsl-78-35-157-23.netcologne.de [78.35.157.23])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by cc-smtpin3.netcologne.de (Postfix) with ESMTPSA;	Tue, 20 Feb 2018 19:59:35 +0100 (CET)
Subject: Re: [patch, fortran] Fix character length in constructors
To: Janne Blomqvist <blomqvist.janne@gmail.com>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
References: <a4470f1d-a946-a5bf-7934-5ef8e88ac3d9@netcologne.de> <CAO9iq9EdSx-07ni3CbBrUzxnVLme-ynSfTrt-r+D_zx95PgU8Q@mail.gmail.com>
From: Thomas Koenig <tkoenig@netcologne.de>
Message-ID: <51ac36d5-cc4a-eebe-f454-fdb355ffc0ad@netcologne.de>
Date: Tue, 20 Feb 2018 18:59:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <CAO9iq9EdSx-07ni3CbBrUzxnVLme-ynSfTrt-r+D_zx95PgU8Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-02/txt/msg01186.txt.bz2

Am 20.02.2018 um 08:51 schrieb Janne Blomqvist:

> It's better to use gfc_mpz_get_hwi() instead of mpz_get_si().
> mpz_get_si() returns a long, which is a 32-bit type on win64.
> 
> Otherwise Ok with the spelling fix suggested by Steve.

Committed as r257856.

Thanks to you and Steve for the review and the heads_up about
gfc_mpz_get_hwi.

I also changed the "call abort" to "STOP 1" at the last second
(old habits are hard to break, it seems :-)

Regards

	Thomas