public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: 程璐璐 <chenglulu@loongson.cn>
To: Xi Ruoyao <xry111@mengyan1223.wang>, gcc-patches@gcc.gnu.org
Cc: Chenghua Xu <xuchenghua@loongson.cn>
Subject: Re: [PATCH] loongarch: testsuite: skip builtin-apply2.c
Date: Sat, 9 Apr 2022 14:06:35 +0800	[thread overview]
Message-ID: <51c1b8e3-f5e0-d0f1-eaca-1f1f6ab9b034@loongson.cn> (raw)
In-Reply-To: <6c4d1585304e757428eee433fb8a98b727c16f76.camel@mengyan1223.wang>


在 2022/4/9 上午5:46, Xi Ruoyao 写道:
> A simple testcase change, tested on loongarch64-linux-gnuabif64.  Ok for trunk?
>
> ---
>
> On LoongArch, variadic functions use different arugment passing
> conventions so this test is not valid (see the section named "Variadic
> argument" in the [ELF ABI][1]) and should be skipped.
>
> [1]: https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html
>
> gcc/testsuite/
>
> 	* gcc.dg/builtin-apply2.c (dg-skip-if): Add loongarch*-*-*.
> ---
>   gcc/testsuite/gcc.dg/builtin-apply2.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/testsuite/gcc.dg/builtin-apply2.c b/gcc/testsuite/gcc.dg/builtin-apply2.c
> index 9049af5821f..0f350f4ac16 100644
> --- a/gcc/testsuite/gcc.dg/builtin-apply2.c
> +++ b/gcc/testsuite/gcc.dg/builtin-apply2.c
> @@ -1,7 +1,7 @@
>   /* { dg-do run } */
>   /* { dg-require-effective-target untyped_assembly } */
>   /* { dg-skip-if "Variadic funcs have all args on stack. Normal funcs have args in registers." { "avr-*-* nds32*-*-* amdgcn-*-*" } } */
> -/* { dg-skip-if "Variadic funcs use different argument passing from normal funcs." { "csky*-*-* riscv*-*-* or1k*-*-* msp430-*-* pru-*-*" } } */
> +/* { dg-skip-if "Variadic funcs use different argument passing from normal funcs." { "csky*-*-* riscv*-*-* or1k*-*-* msp430-*-* pru-*-* loongarch*-*-*" } } */
>   /* { dg-skip-if "Variadic funcs use Base AAPCS.  Normal funcs use VFP variant." { arm*-*-* && arm_hf_eabi } } */
>   
>   /* PR target/12503 */


OK.

Thanks!

LuluCheng


      reply	other threads:[~2022-04-09  6:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08 21:46 Xi Ruoyao
2022-04-09  6:06 ` 程璐璐 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51c1b8e3-f5e0-d0f1-eaca-1f1f6ab9b034@loongson.cn \
    --to=chenglulu@loongson.cn \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=xry111@mengyan1223.wang \
    --cc=xuchenghua@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).