From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 4DA49385E839 for ; Fri, 17 Mar 2023 10:14:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4DA49385E839 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A76961480; Fri, 17 Mar 2023 03:14:58 -0700 (PDT) Received: from [10.57.65.37] (unknown [10.57.65.37]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 52A423F64C; Fri, 17 Mar 2023 03:14:14 -0700 (PDT) Message-ID: <51ce8969-3130-452e-092e-f9d91eff2dad@arm.com> Date: Fri, 17 Mar 2023 10:14:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [ping][vect-patterns] Refactor widen_plus/widen_minus as internal_fns Content-Language: en-US To: Richard Biener Cc: Richard Sandiford , "gcc-patches@gcc.gnu.org" References: From: "Andre Vieira (lists)" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Richard, I'm only picking this up now. Just going through your earlier comments and stuff and I noticed we didn't address the situation with the gimple::build. Do you want me to add overloaded static member functions to cover all gimple_build_* functions, or just create one to replace vect_gimple_build and we create them as needed? It's more work but I think adding them all would be better. I'd even argue that it would be nice to replace the old ones with the new ones, but I can imagine you might not want that as it makes backporting and the likes a bit annoying... Let me know what you prefer, I'll go work on your latest comments too. Cheers, Andre