From: Richard Henderson <rth@redhat.com>
To: Aldy Hernandez <aldyh@redhat.com>
Cc: "Iyer, Balaji V" <balaji.v.iyer@intel.com>,
Jeff Law <law@redhat.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C
Date: Tue, 06 Aug 2013 17:04:00 -0000 [thread overview]
Message-ID: <52012C8F.6050605@redhat.com> (raw)
In-Reply-To: <52012923.6030409@redhat.com>
On 08/06/2013 06:49 AM, Aldy Hernandez wrote:
>> --- gcc/ipa-inline-analysis.c
>> +++ gcc/ipa-inline-analysis.c
>> @@ -1433,6 +1433,9 @@ initialize_inline_failed (struct cgraph_edge *e)
>> e->inline_failed = CIF_REDEFINED_EXTERN_INLINE;
>> else if (e->call_stmt_cannot_inline_p)
>> e->inline_failed = CIF_MISMATCHED_ARGUMENTS;
>> + else if (flag_enable_cilkplus && cfun && cfun->calls_spawn)
>> + /* We can't inline if the function is spawing a function. */
>> + e->inline_failed = CIF_BODY_NOT_AVAILABLE;
>
> Hmmm, if we don't have a cfun, perhaps we should be sticking this calls_spawn
> bit in the cgraph node.
>
> Richard? Anyone?
There will always be a function struct. Probably not cfun though.
You can get to the callee through the edge.
"BODY_NOT_AVAILABLE"? Definitely an odd error message to have chosen
for this...
r~
next prev parent reply other threads:[~2013-08-06 17:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 20:48 Iyer, Balaji V
2013-08-06 16:49 ` Aldy Hernandez
2013-08-06 17:04 ` Richard Henderson [this message]
2013-08-08 19:33 ` Iyer, Balaji V
2013-08-09 10:40 ` Aldy Hernandez
2013-08-13 20:32 ` Iyer, Balaji V
2013-08-19 22:24 ` Aldy Hernandez
2013-08-21 23:08 ` Iyer, Balaji V
2013-08-20 22:28 ` Aldy Hernandez
2013-08-21 4:35 ` Iyer, Balaji V
2013-08-21 15:49 ` Aldy Hernandez
2013-08-21 19:21 ` Jeff Law
2013-08-21 20:02 ` Iyer, Balaji V
2013-08-22 16:53 ` Aldy Hernandez
2013-08-27 22:29 ` FW: " Iyer, Balaji V
2014-09-22 13:57 ` Thomas Schwinge
2014-09-22 19:28 ` Tannenbaum, Barry M
2014-09-29 10:54 ` Thomas Schwinge
2014-09-29 13:59 ` Tannenbaum, Barry M
2014-09-29 14:26 ` Thomas Schwinge
2014-09-29 14:56 ` Tannenbaum, Barry M
2014-09-29 15:24 ` Jeff Law
2016-03-28 18:05 ` Ilya Verbin
2016-03-29 16:02 ` Thomas Schwinge
2016-03-29 16:19 ` Ilya Verbin
[not found] ` <BF230D13CA30DD48930C31D4099330003A45D42C@FMSMSX101.amr.corp.intel.com>
2013-08-28 18:38 ` Aldy Hernandez
2013-08-30 17:02 ` FW: " Iyer, Balaji V
[not found] ` <BF230D13CA30DD48930C31D4099330003A45F32A@FMSMSX101.amr.corp.intel.com>
2013-09-02 13:10 ` Aldy Hernandez
2013-08-09 16:52 ` Joseph S. Myers
2013-08-13 20:33 ` Iyer, Balaji V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52012C8F.6050605@redhat.com \
--to=rth@redhat.com \
--cc=aldyh@redhat.com \
--cc=balaji.v.iyer@intel.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).